[coreboot] RFC: coding style: "standard" defines

ron minnich rminnich at gmail.com
Mon Feb 8 17:06:29 CET 2016


makes sense to me.

On Mon, Feb 8, 2016 at 3:10 AM Patrick Georgi via coreboot <
coreboot at coreboot.org> wrote:

> 2016-02-04 10:35 GMT+01:00 Patrick Georgi <pgeorgi at google.com>:
> > during the review of some commits that are in the process of being
> > upstreamed from Chrome OS, people noticed that chipset drivers like to
> > define their own TRUE/FALSE defines (sometimes prefixed to), and I
> > have seen a bunch of #define BIT{0-31} ..., too, because that seems to
> > be the house rules in some firmware communities.
> Seems like for the BIT defines, all variants are popular. Any
> objection with moving them to src/include instead of having various
> copies across the tree?
>
>
> Patrick
> --
> Google Germany GmbH, ABC-Str. 19, 20354 Hamburg
> Registergericht und -nummer: Hamburg, HRB 86891, Sitz der Gesellschaft:
> Hamburg
> Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle
>
> --
> coreboot mailing list: coreboot at coreboot.org
> http://www.coreboot.org/mailman/listinfo/coreboot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.coreboot.org/pipermail/coreboot/attachments/20160208/58d1bea6/attachment.html>


More information about the coreboot mailing list