<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=UTF-8" http-equiv="Content-Type">
<title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
Carl-Daniel Hailfinger wrote:
<blockquote cite="mid:47B82A14.5020204@gmx.net" type="cite">
<pre wrap="">On 17.02.2008 13:02, Carl-Daniel Hailfinger wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On 17.02.2008 05:02, Peter Stuge wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On Sun, Feb 17, 2008 at 12:34:24AM +0100, Carl-Daniel Hailfinger wrote:
</pre>
<blockquote type="cite">
<pre wrap="">+enum compalgo {
+ none = 0,
+ lzma = 1,
+ nrv2b = 2,
+ zeroes = 3,
+ /* invalid should always be the last entry. */
+ invalid
+};
</pre>
</blockquote>
<pre wrap="">It's fairly common to uppercase these. Do we want that too?
</pre>
</blockquote>
<pre wrap="">This was just a straight copy from util/lar, but I agree. We use these
enums like #defines, so uppercasing seems indeed the best way to bring
this hint to the developer.
</pre>
</blockquote>
<pre wrap=""><!---->
Uppercasing also found a name clash between NONE as compression algo and
NONE as operation mode of util/lar.
Print name of compression algorithm in addition to the corresponding
number during boot.
Convert process_file() to use enum compalgo instead of hardcoded
"1","2","3" and change the control structure from a series of if()
statements to a switch() statement.
Compile and boot tested on Qemu.
Signed-off-by: Carl-Daniel Hailfinger <a class="moz-txt-link-rfc2396E" href="mailto:c-d.hailfinger.devel.2006@gmx.net"><c-d.hailfinger.devel.2006@gmx.net></a>
</pre>
</blockquote>
<br>
Acked-by: Stefan Reinauer <a class="moz-txt-link-rfc2396E" href="mailto:stepan@coresystems.de"><stepan@coresystems.de></a><br>
<br>
<br>
<br>
Stefan<br>
<br>
<pre class="moz-signature" cols="72">--
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: <a class="moz-txt-link-abbreviated" href="mailto:info@coresystems.de">info@coresystems.de</a> • <a class="moz-txt-link-freetext" href="http://www.coresystems.de/">http://www.coresystems.de/</a>
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866
</pre>
</body>
</html>