<html>
<head>
<style>
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
FONT-SIZE: 10pt;
FONT-FAMILY:Tahoma
}
</style>
</head>
<body class='hmmessage'>
Ulf Jordan wrote:<br>> On Fri, 11 Apr 2008, svn@coreboot.org wrote:<br>> <br>>> +int isxdigit(int c)<br>>> +{<br>>> + return isdigit(c) || (tolower(c)>= 'a' && tolower(c) <= 'z');<br>>> +}<br>> <br>> Shouldn't this be<br>> <br>> return isdigit(c) || (tolower(c)>= 'a' && tolower(c) <= 'f');<br>jep it should..<br>but why not :<br> return isdigit(c) || c>= 'a' && c <= 'f' || c>= 'A' && c <= 'F' );<br>it might be even faster if you do<br>return isdigit(c) || (c & ~0x20)>= 'A' && (c & ~0x20) <= 'F' );<br>> <br>> <br>> /ulf<br>> <br><br><br><br /><hr />Express yourself instantly with MSN Messenger! <a href='http://clk.atdmt.com/AVE/go/onm00200471ave/direct/01/' target='_new'>MSN Messenger</a></body>
</html>