<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html;charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Marc Jones wrote:
<blockquote cite="mid:4846C701.2000406@amd.com" type="cite">
<pre wrap="">ron minnich wrote:
</pre>
<blockquote type="cite">
<pre wrap="">This change adds some debug prints, and a comment warning to dts on cs5536.
Most importantly it fixes a simple programming error which made it so most of
the sets on the USB were not doing anything. The bug is also in V2.
</pre>
</blockquote>
<pre wrap=""><!---->
</pre>
<blockquote type="cite">
<pre wrap="">/* the /sizeof(u32) is to convert byte offsets into u32 offsets */
#define HCCPARAMS (0x08/sizeof(u32))
</pre>
</blockquote>
<pre wrap=""><!---->
I don't understand this change. This is standard MMIO. The memory mapped
registers are defined 0h, 04h, 08h, 0Ah...
You could
*(bar + 08h) |= 1 << 9;
or
*(bar + 09h) |= 1 << 1;
</pre>
</blockquote>
<br>
Yes, this looks much saner... <br>
<br>
on i945 i am using a couple of defines for accessing MMIO registers (in
this case the MCHBAR registers)<br>
<br>
#define MCHBAR8(x) *((volatile u8 *)(DEFAULT_MCHBAR + x))<br>
#define MCHBAR16(x) *((volatile u16 *)(DEFAULT_MCHBAR + x))<br>
#define MCHBAR32(x) *((volatile u32 *)(DEFAULT_MCHBAR + x))<br>
<br>
so you can write<br>
<br>
MCHBAR8(DCC) |= (1<<1);<br>
<br>
for maximum readablility<br>
<br>
<br>
<blockquote cite="mid:4846C701.2000406@amd.com" type="cite">
<pre wrap="">Can you please explain?
</pre>
</blockquote>
<br>
<br>
<br>
<pre class="moz-signature" cols="72">--
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: <a class="moz-txt-link-abbreviated" href="mailto:info@coresystems.de">info@coresystems.de</a> • <a class="moz-txt-link-freetext" href="http://www.coresystems.de/">http://www.coresystems.de/</a>
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866
</pre>
</body>
</html>