<html>
<head>
<style>
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
FONT-SIZE: 10pt;
FONT-FAMILY:Tahoma
}
</style>
</head>
<body class='hmmessage'>
im i the progress of parsing my old email and have a question:<br>- why not output something like "superiotool r2828 (2814:2828M)" or <br>"superiotool r2828 (details:2814:2828M)"<br><br><br>Ulf Jordan wrote:<br>> On Mon, 8 Oct 2007, Uwe Hermann wrote:<br>>> On Sun, Oct 07, 2007 at 11:09:24AM +0200, Ulf Jordan wrote:<br>>>> Attached is a patch that:<br>>>><br>>>> * derives the superiotool version number from the latest committed <br>>>> change<br>>>> to superiotool files (NOT the latest svn up of the superiotool <br>>>> directory)<br>>><br>>> Hm, isn't that wrong? We want to know the extact version from which the<br>>> binary was built, _not_ the most current version in the repository at the<br>>> time it was built...<br>> <br>> My formulation was inexact. svnversion shows the local revisions of the <br>> working copy, not the repository. What I meant to say was:<br>> <br>> * derives the superiotool version number from the highest revision <br>> number of the checked out superiotool files (NOT the revision number <br>> from latest svn up of the superiotool directory)<br>> <br>>>> * strips away extra information from svnversion, to arrive at a single<br>>>> version number like 2828 instead of 2814:2828M ("this build is made <br>>>> up of<br>>>> files with latest modification in rev 2814 to 2828 plus local<br>>>> modifications").<br>>><br>>> Hm, maybe that would even be a good thing? We could tell from that<br>>> output that a user used a modified version and ask for a diff...<br>> <br>> Yes maybe. More information at the expense of a more odd looking version <br>> number.<br>> <br>> The stripping is implemented by the sed invocation, without which we <br>> would get the more detailed information. I'll leave it as is, awaiting <br>> further discussion on what we actually want to show in the version number.<br>> <br>>>> This approach could easily be combined with a traditional version number<br>>>> from a #define in superiotool.h, as Robinson pointed out.<br>>><br>>> Not needed and not useful. We don't want to confuse people with _two_<br>>> versioning systems.<br>> <br>> OK.<br>> <br>>>> Index: Makefile<br>>>> ===================================================================<br>>>> --- Makefile (revision 2828)<br>>>> +++ Makefile (working copy)<br>>>> @@ -24,14 +24,19 @@<br>>>> INSTALL = /usr/bin/install<br>>>> PREFIX = /usr/local<br>>>><br>>>> +SVNDEF := -D'SUPERIOTOOL_VERSION="$(shell svnversion -cn . \<br>>>> + | sed -e "s/.*://" -e "s/\([0-9]*\).*/\1/")"'<br>>><br>>> Please add a comment here which explains what the contents of the<br>>> variable will be (svn rev of latest commit etc...), how it works, etc.<br>> <br>> OK, added.<br>> <br>> Attached is an updated patch.<br>> <br>> /ulf<br>> <br><br><br /><hr />Express yourself instantly with MSN Messenger! <a href='http://clk.atdmt.com/AVE/go/onm00200471ave/direct/01/' target='_new'>MSN Messenger</a></body>
</html>