<br><br><div class="gmail_quote">On Thu, Nov 13, 2008 at 11:30 AM, Marc Jones <span dir="ltr"><<a href="mailto:marcj303@yahoo.com">marcj303@yahoo.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div><div style="font-family: garamond,new york,times,serif; font-size: 12pt;"><div class="Ih2E3d">Myles,<br><br>I think that this is going to right direction. There are a couple things that I don't understand.<br><br>
Why is there a w83627hf_pnp_ops and w83627hf_ops? Can they be combined?</div></div></div></blockquote><div><br>The problem is that one is the parent, and one is for the children. The parent's ops just iterates through the children and calls the correct functions. If you don't have that, then the childrens' functions never get called.<br>
</div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div><div style="font-family: garamond,new york,times,serif; font-size: 12pt;"><div class="Ih2E3d">
And this is why there are two dts files, pnp.dts and dts?<br></div></div></div></blockquote><div><br>I wanted to simplify the code that took the information from the dts and passed it to the PNP code. If you just have a big list of attributes, you have to figure out which attribute goes with which function number and pass them to the PNP code. Having devices already created with the correct function numbers seems less error-prone to me.<br>
</div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div><div style="font-family: garamond,new york,times,serif; font-size: 12pt;"><div class="Ih2E3d">
<br>I
don't think each device should have io, io1, io2, etc. They only need
whatever is required to fill the entry in pnp_dev_info[].</div></div></div></blockquote><div><br>I agree. I just didn't want to create w83627hf_kbd.dts and friends, because then I'd be at the same place with lots of code to pass the arguments.<br>
</div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div><div style="font-family: garamond,new york,times,serif; font-size: 12pt;"><div class="Ih2E3d">
And so there isn't a stock pnp dts entry. Each should be specific for the device (kbc, uart, etc) but generic names.</div></div></div></blockquote><div><br>I don't understand what you mean.<br> <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div><div style="font-family: garamond,new york,times,serif; font-size: 12pt;"><div class="Ih2E3d">Thanks for the clarification.<br></div></div></div></blockquote><div><br>Thanks for questioning. It helps.<br><br>Myles<br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div><div style="font-family: garamond,new york,times,serif; font-size: 12pt;"><div class="Ih2E3d">
<br>Marc<div> </div>--<br><a href="http://marcjstuff.blogspot.com/" target="_blank">http://marcjstuff.blogspot.com/</a><div><br></div></div><div style="font-family: garamond,new york,times,serif; font-size: 12pt;"><br><div style="font-family: times new roman,new york,times,serif; font-size: 12pt;">
<font size="2" face="Tahoma"><div class="Ih2E3d"><hr size="1"><b><span style="font-weight: bold;">From:</span></b> Myles Watson <<a href="mailto:mylesgw@gmail.com" target="_blank">mylesgw@gmail.com</a>><br><b><span style="font-weight: bold;">To:</span></b> ron minnich <<a href="mailto:rminnich@gmail.com" target="_blank">rminnich@gmail.com</a>><br>
<b><span style="font-weight: bold;">Cc:</span></b> Coreboot <<a href="mailto:coreboot@coreboot.org" target="_blank">coreboot@coreboot.org</a>><br><b><span style="font-weight: bold;">Sent:</span></b> Thursday, November 13, 2008 10:29:08 AM<br>
</div><div class="Ih2E3d"><b><span style="font-weight: bold;">Subject:</span></b> Re: [coreboot] Resource
allocation<br></div></font><br>
<br><div><div></div><div class="Wj3C7c"><br><div class="gmail_quote">On Thu, Nov 13, 2008 at 8:58 AM, ron minnich <span dir="ltr"><<a rel="nofollow" href="mailto:rminnich@gmail.com" target="_blank">rminnich@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div>On Thu, Nov 13, 2008 at 6:03 AM, Myles Watson <<a rel="nofollow" href="mailto:mylesgw@gmail.com" target="_blank">mylesgw@gmail.com</a>> wrote:<br></div><div><br>
> That makes it clear which devices get created (all the ones mentioned in the<br>
> dts.) Then the SIO code can take care of special cases like devices that<br>
> need to be set even when they're disabled.<br>
<br>
</div>yes, but this is *exactly* the model that people are objecting to in<br>
the other thread. We kind of need to make up our mind here.<br><div></div></blockquote><div><br>How about we get something working, then improve on it. Here's my latest try.<br> <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div>
><br>
> While I'm wishing I'd like to use pnp@W83627HF_KBC instead of pnp@5 and have<br>
> that just work. I think it might not be too hard, but it's a syntax error<br>
> now. It would definitely reduce the chance for mistakes.<br>
<br>
</div>I would rather not do this.</blockquote><div> </div><div>OK. It's bitten me once, but I'll be more careful. <br></div><div> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div>
> That's right. The problem is that there needs to be some generic way to<br>
> pass this information to the resource code.<br>
<br>
</div>This is actually not even v2, it's v1. It did not work because you<br>
have resources in that struct that don't<br>
exist on many devices, and there are always new devices with new<br>
resource types that break the model.<br>
<div><br>
> Right now it allocates a new<br>
> device for each of the SuperIO PNP functions, so there are dynamic devices<br>
> for all of them. I think that there should only be dynamic devices for<br>
> things that get plugged in.<br>
<br>
</div>I am still not convinced this really matters.<font color="#888888"></font></blockquote><div><br>I'm attaching two logs. One is without the attached patch, the other with. It fixes resource allocation and makes the logs much cleaner, but it doesn't make the box work correctly. It's just hard to debug too many things at once. I'd like to get the SuperIO working, then resource allocation, then VGA if its still broken, then HT ...<br>
<br>The patch won't apply for you because it depends on other code in the tree. There's just too much to send now, and I haven't gotten organized enough to use Jordan's script yet.<br><br>Signed-off-by: Myles Watson <<a rel="nofollow" href="mailto:mylesgw@gmail.com" target="_blank">mylesgw@gmail.com</a>><br>
<br>Thanks,<br>Myles <br></div></div><br>
</div></div></div></div></div></div></blockquote></div><br>