<div dir="ltr"><br><br><div class="gmail_quote">On Mon, Nov 17, 2008 at 5:30 AM, Joseph Smith <span dir="ltr"><<a href="mailto:joe@settoplinux.org">joe@settoplinux.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
<br>
<br>
On Mon, 17 Nov 2008 04:25:34 +0200, "Elia Yehuda" <<a href="mailto:z4ziggy@gmail.com">z4ziggy@gmail.com</a>><br>
wrote:<br>
<div><div></div><div class="Wj3C7c">> Those 2 patches are one step towards having a working Onboard-VGA<br>
> and 512MB (the max for i810). The raminit.c patch fixes some<br>
> misconfigurations and probes the DIMMs correctly (all dual-sided are<br>
> now recognized properly), and also set buffer_strength to handle 2<br>
> DIMMs although atm this doesn't work. The i82810/northbridge.c patch<br>
> takes care of allocating Onboard-VGA memory.<br>
><br>
> Signed-off-by: Elia Yehuda <<a href="mailto:z4ziggy@gmail.com">z4ziggy@gmail.com</a>><br>
<br>
</div></div>Sorry I'm going to have to nack your northbridge.patch.<br>
<br>
Your VGA memory has to be subtracted from tomk in kb,like this:<br>
<br>
#ifdef CONFIG_VIDEO_MB<br>
/* check for VGA reserved memory<br>
* possible CONFIG_VIDEO_MB values are 512(kb) and 1(mb)<br>
*/<br>
if (CONFIG_VIDEO_MB == 512) {<br>
tomk -= 512;<br>
} else if (CONFIG_VIDEO_MB == 1) {<br>
tomk -= 1024;<br>
} else {<br>
/* assume no vga if incorrect value */<br>
tomk == tomk;<br>
#endif<br>
</blockquote><div><br><br>the place ive added this is when tomk is still set as MBs. Ofcourse i can move<br>this a few lines down after tomk is converted to KBs. Ive just put it there to be<br>before the printk_debug("Setting RAM size to %d MB\n", tomk) so we can see<br>
how much MBs are subtracted from tomk.<br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
Also Make sure you have already set the CONFIG_VIDEO_MB value in your<br>
northbridge vga memory register. I would recomend this earlier in<br>
raminit.c. Clue from i82830 raminit.c:<br>
<br>
/* Set the value for GMCH Control Register #1 */<br>
switch (CONFIG_VIDEO_MB) {<br>
case 512: /* 512K of memory */<br>
igd_memory = 0x2;<br>
break;<br>
case 1: /* 1M of memory */<br>
igd_memory = 0x3;<br>
break;<br>
case 8: /* 8M of memory */<br>
igd_memory = 0x4;<br>
break;<br>
default: /* No memory */<br>
pci_write_config16(ctrl->d0, GCC1, 0x0002);<br>
igd_memory = 0x0;<br>
}<br>
<br>
value = pci_read_config16(ctrl->d0, GCC1);<br>
value |= igd_memory << 4;<br>
pci_write_config16(ctrl->d0, GCC1, value);<br>
</blockquote><div><br>more of the lines of : ?<br><br> /* set System Management RAM Control Register / Graphics Mode Select */<br> value = pci_read_config8(ctrl->d0, SMRAM);<br> /* Set size for Onboard-VGA framebuffer. */<br>
switch (CONFIG_VIDEO_MB) {<br> case 512: /* 512K of memory */<br> val = 0x2;<br> break;<br> case 1: /* 1M of memory */<br> val = 0x3;<br> break;<br> default: /* No VGA memory */<br>
/* Preserve bits except for GMS */<br> value &= 0x3f;<br> pci_write_config16(ctrl->d0, SMRAM, value);<br> val = 0x0;<br> }<br> value |= val << 6;<br> /* set AB segment Enabled as SMM RAM */<br>
value |= 0x0C;<br> pci_write_config8(ctrl->d0, SMRAM, value);<br><br><br>do notice ive removed the 8MB option since i810 doesn't support this.<br> <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
<br>
Hope that helps.</blockquote><div><br>always appreciated.<br><br>Elia.<br> <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
<font color="#888888"><br>
--<br>
Thanks,<br>
Joseph Smith<br>
Set-Top-Linux<br>
<a href="http://www.settoplinux.org" target="_blank">www.settoplinux.org</a><br>
<br>
</font></blockquote></div><br></div>