<br><div class="gmail_quote">On Wed, Dec 10, 2008 at 10:34 AM, Ward Vandewege <span dir="ltr"><<a href="mailto:ward@gnu.org">ward@gnu.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div class="Ih2E3d">On Wed, Dec 10, 2008 at 10:06:24AM -0700, Abhishek Kulkarni wrote:<br>
> On Wed, Dec 10, 2008 at 10:00 AM, Ward Vandewege <<a href="mailto:ward@gnu.org">ward@gnu.org</a>> wrote:<br>
><br>
> On Wed, Dec 10, 2008 at 09:50:12AM -0700, Abhishek Kulkarni wrote:<br>
> > openvsa.inc has no OPENVSA_LOG_DIR target, and considering that<br>
> > $(SOURCE_DIR)/$(OPENVSA_TARBALL) creates the LOG_DIR we don't need<br>
> to add<br>
> > dependency on the LOG_DIR.<br>
><br>
> Actually, let's do it the other way around and remove that<br>
> @ mkdir -p $(OPENVSA_LOG_DIR)<br>
><br>
> while keeping the dependency on $(OPENVSA_LOG_DIR).<br>
><br>
> That's cleaner. OK?<br>
><br>
> Sure, makes sense.<br>
><br>
> Also, most of the main targets already have a dependency on the LOG_DIR<br>
> targets. Is there a specific reason to add it to the TARBALL_TARGET too?<br>
<br>
</div>Yes:<br>
<div class="Ih2E3d"><br>
@ $(BIN_DIR)/fetchsvn.sh $(OPENVSA_URL) $(SOURCE_DIR)/openvsa \<br>
$(OPENVSA_TAG) $@ > $(OPENVSA_FETCH_LOG) 2>&1<br>
<br>
</div>$(OPENVSA_FETCH_LOG) is made up from $(OPENVSA_LOG_DIR), so it has to exist<br>
before this target is called.<br>
<br>
> Corrected patch below:<br>
<br>
Can you sign it off as per the guidelines at<br>
<br>
<a href="http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure" target="_blank">http://www.coreboot.org/Development_Guidelines#Sign-off_Procedure</a><br>
<br>
In fact that entire page is good reading :)</blockquote><div><br>Yes, indeed :) I figured I don't have commit access, so I skipped the SOB part. <br>Here it goes again:<br><br><br>Minor buildrom Makefile fix for geodvesa/openvesa.inc.<br>
This patch adds a OPENVSA_LOG_DIR target and removes the redundant calls which create OPENVESA_LOG_DIR.<br><br>Signed-off-by: Abhishek Kulkarni <<a href="mailto:adkulkar@cs.indiana.edu">adkulkar@cs.indiana.edu</a>><br>
<br>----<br><br>Index: geodevsa/openvsa.inc<br>===================================================================<br><div class="Ih2E3d">--- geodevsa/openvsa.inc (revision 255)<br>+++ geodevsa/openvsa.inc (working copy)<br>
</div>
@@ -19,7 +19,6 @@<div class="Ih2E3d"><br> <br> $(SOURCE_DIR)/$(OPENVSA_TARBALL): | $(OPENVSA_LOG_DIR)<br></div><div class="Ih2E3d"> @ mkdir -p $(SOURCE_DIR)/openvsa<br></div>- @ mkdir -p $(OPENVSA_LOG_DIR)<br> @ echo "Fetching openvsa..."<br>
@ $(BIN_DIR)/fetchsvn.sh $(OPENVSA_URL) $(SOURCE_DIR)/openvsa \<br>
$(OPENVSA_TAG) $@ > $(OPENVSA_FETCH_LOG) 2>&1<br>@@ -31,7 +30,6 @@<br> @ touch $@<br> <br> $(OPENVSA_SRC_DIR)/vsa_lx.<div>bin: $(OPENVSA_STAMP_DIR)/.unpacked<br>- @ mkdir -p $(OPENVSA_LOG_DIR)<br> @ echo "Building openvsa..."<br>
@(unset LDFLAGS; $(MAKE) -C $(OPENVSA_SRC_DIR) \<br> > $(OPENVSA_BUILD_LOG) 2>&1)<br>@@ -40,6 +38,9 @@<br> @ mkdir -p $(shell dirname $(GEODE_UNCOMPRESSED_VSA))<br> @ cp $< $@<br> <br>+$(OPENVESA_STAMP_DIR) $(OPENVESA_LOG_DIR):<br>
+ @ mkdir -p $@<br>+<br> openvsa: $(OPENVSA_SRC_DIR)/vsa_lx.bin<br> <br> openvsa-clean:</div><br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
<div><div></div><div class="Wj3C7c"><br>
Thanks,<br>
Ward.<br>
<br>
--<br>
Ward Vandewege <<a href="mailto:ward@fsf.org">ward@fsf.org</a>><br>
Free Software Foundation - Senior Systems Administrator<br>
</div></div></blockquote></div><br>