<br><br><div class="gmail_quote">On Thu, Dec 18, 2008 at 8:13 PM, Myles Watson <span dir="ltr"><<a href="mailto:mylesgw@gmail.com">mylesgw@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br><br><div class="gmail_quote"><div><div></div><div class="Wj3C7c">On Thu, Dec 18, 2008 at 5:16 PM, Marc Jones <span dir="ltr"><<a href="mailto:marcj303@gmail.com" target="_blank">marcj303@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div><div></div><div>On Thu, Dec 18, 2008 at 12:10 PM, Myles Watson <<a href="mailto:mylesgw@gmail.com" target="_blank">mylesgw@gmail.com</a>> wrote:<br>
><br>
><br>
> On Thu, Dec 18, 2008 at 11:42 AM, coreboot information <<a href="mailto:info@coresystems.de" target="_blank">info@coresystems.de</a>><br>
> wrote:<br>
>><br>
>> Dear coreboot readers!<br>
>><br>
>> This is the automated build check service of coreboot.<br>
>><br>
>> The developer "myles" checked in revision 3818 to<br>
>> the coreboot source repository and caused the following<br>
>> changes:<br>
>><br>
>> Change Log:<br>
>> This patch gets rid of all the implicit definition warnings for serengeti<br>
>> except get_nodes.<br>
>><br>
>> Signed-off-by: Myles Watson <<a href="mailto:mylesgw@gmail.com" target="_blank">mylesgw@gmail.com</a>><br>
>> Acked-by: Marc Jones <<a href="mailto:marcj303@gmail.com" target="_blank">marcj303@gmail.com</a>><br>
>><br>
>><br>
>> Build Log:<br>
>> Compilation of asus:m2v-mx_se has been broken<br>
>> See the error log at<br>
>> <a href="http://qa.coreboot.org/log_buildbrd.php?revision=3818&device=m2v-mx_se&vendor=asus" target="_blank">http://qa.coreboot.org/log_buildbrd.php?revision=3818&device=m2v-mx_se&vendor=asus</a><br>
><br>
> Should this board have HAVE_HARD_RESET 1? That fixes the build. If not,<br>
> I'm not sure how to fix the macro definition of hard_reset in<br>
> src/include/part/hard_reset.h. It seems strange to hang without a message,<br>
> but that's not what's causing the build failure.<br>
<br>
</div></div>Yes, I think that is the problem. It has a hard reset function in<br>
cache_as_ram_auto.c but the function is empty. Remove the function and<br>
leave the macro?</blockquote></div></div><div><br>Then the build is still broken. The empty function says that the board should have a hard_reset, but it's not implemented. I think the right thing to do is define HAVE_HARD_RESET and add a #warning that it isn't implemented. Thoughts?<br>
<br>Thanks,<br>Myles<br></div></div><br>
</blockquote></div><br>Index: src/mainboard/asus/m2v-mx_se/Options.lb<br>===================================================================<br>--- src/mainboard/asus/m2v-mx_se/Options.lb (revision 3820)<br>+++ src/mainboard/asus/m2v-mx_se/Options.lb (working copy)<br>
@@ -96,7 +96,7 @@<br> default ROM_SIZE = 512 * 1024<br> default FALLBACK_SIZE = 256 * 1024<br> default HAVE_FALLBACK_BOOT = 1<br>-default HAVE_HARD_RESET = 0<br>+default HAVE_HARD_RESET = 1<br> default HAVE_PIRQ_TABLE = 0<br>
default IRQ_SLOT_COUNT = 11 # FIXME?<br> default HAVE_MP_TABLE = 1<br>Index: src/mainboard/asus/m2v-mx_se/cache_as_ram_auto.c<br>===================================================================<br>--- src/mainboard/asus/m2v-mx_se/cache_as_ram_auto.c (revision 3820)<br>
+++ src/mainboard/asus/m2v-mx_se/cache_as_ram_auto.c (working copy)<br>@@ -126,6 +126,7 @@<br> {<br> }<br><br>+#warning No hard_reset implemented for this board!<br> void hard_reset(void)<br> {<br> print_info("NO HARD RESET. FIX ME!\n");<br>
<br>This patch fixes the build for asus/m2v-mx_se. Its hard_reset function is not<br>implemented (It just prints "hard_reset not implemented. FIX ME!" This patch<br>defines HAVE_HARD_RESET 1 and adds a #warning hard_reset not implemented.<br>
<br>The net effect is that hard_reset prints something instead of just entering an<br>infinite loop.<br><br>Signed-off-by: Myles Watson <<a href="mailto:mylesgw@gmail.com">mylesgw@gmail.com</a>><br><br>Thanks,<br>Myles<br>
<br>