On Fri, Dec 19, 2008 at 4:12 AM, Bao, Zheng <span dir="ltr"><<a href="mailto:Zheng.Bao@amd.com">Zheng.Bao@amd.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div link="blue" vlink="blue" lang="EN-US">
<div>
<p><font color="navy" size="2" face="Arial"><span style="font-size: 10pt; font-family: Arial; color: navy;">Signed-off-by: Maggie Li <a href="mailto:Maggie.li@amd.com" target="_blank">Maggie.li@amd.com</a></span></font></p>
<p><font color="navy" size="2" face="Arial"><span style="font-size: 10pt; font-family: Arial; color: navy;">Reviewed-by: Zheng bao <<a href="mailto:Zheng.bao@amd.com" target="_blank">Zheng.bao@amd.com</a>></span></font></p>
<p><font color="navy" size="2" face="Arial"><span style="font-size: 10pt; font-family: Arial; color: navy;"> </span></font></p>
<div>
<div style="text-align: center;" align="center"><font size="3" face="Times New Roman"><span style="font-size: 12pt;">
<hr align="center" size="2" width="100%">
</span></font></div>
<p><b><font size="2" face="Tahoma"><span style="font-size: 10pt; font-family: Tahoma; font-weight: bold;">From:</span></font></b><font size="2" face="Tahoma"><span style="font-size: 10pt; font-family: Tahoma;">
<a href="mailto:coreboot-bounces@coreboot.org" target="_blank">coreboot-bounces@coreboot.org</a> [mailto:<a href="mailto:coreboot-bounces@coreboot.org" target="_blank">coreboot-bounces@coreboot.org</a>] <b><span style="font-weight: bold;">On Behalf Of </span></b>Li,
Maggie<br>
<b><span style="font-weight: bold;">Sent:</span></b> Friday, December 19, 2008
4:56 PM<br>
<b><span style="font-weight: bold;">To:</span></b> Coreboot<br>
<b><span style="font-weight: bold;">Subject:</span></b> Re: [coreboot] [RFC]
Error out on implicit declarations</span></font></p>
</div><div><div></div><div class="Wj3C7c">
<p><font size="3" face="Times New Roman"><span style="font-size: 12pt;"> </span></font></p>
<p><font color="navy" size="2" face="Times New Roman"><span style="font-size: 10pt; color: navy;">Hi, </span></font></p>
<p><font color="navy" size="2" face="Times New Roman"><span style="font-size: 10pt; color: navy;"> </span></font></p>
<p><font color="navy" size="3" face="Times New Roman"><span style="font-size: 12pt; color: navy;">Here are the patches for fixing implicit
declarations in amdk8, dbm690t and pistachio.</span></font></p>
<p><font color="navy" size="3" face="Times New Roman"><span style="font-size: 12pt; color: navy;">Please help me check it. Thanks.</span></font></p></div></div></div></div></blockquote><div><br>Thanks for the patches, but I think they've broken other boards, and I'd rather not check in a patch that breaks what currently builds. The main ones I'm at are the agami aruma:<br>
<br>In file included from /home/corey/coreboot/coreboot-v2/src/southbridge/amd/amd8111/../../../northbridge/amd/amdk8/reset_test.c:3,<br> from /home/corey/coreboot/coreboot-v2/src/southbridge/amd/amd8111/amd8111_reset.c:54:<br>
/home/corey/coreboot/coreboot-v2/src/arch/i386/include/arch/romcc_io.h:74:1: warning: "PCI_DEV" redefined<br>/home/corey/coreboot/coreboot-v2/src/southbridge/amd/amd8111/amd8111_reset.c:4:1: warning: this is the location of the previous definition<br>
In file included from /home/corey/coreboot/coreboot-v2/src/southbridge/amd/amd8111/../../../northbridge/amd/amdk8/reset_test.c:3,<br> from /home/corey/coreboot/coreboot-v2/src/southbridge/amd/amd8111/amd8111_reset.c:54:<br>
/home/corey/coreboot/coreboot-v2/src/arch/i386/include/arch/romcc_io.h:85: error: redefinition of typedef 'device_t'<br>/home/corey/coreboot/coreboot-v2/src/southbridge/amd/amd8111/amd8111_reset.c:12: error: previous declaration of 'device_t' was here<br>
/home/corey/coreboot/coreboot-v2/src/arch/i386/include/arch/romcc_io.h:174: error: redefinition of 'pci_read_config32'<br>/home/corey/coreboot/coreboot-v2/src/southbridge/amd/amd8111/amd8111_reset.c:31: error: previous definition of 'pci_read_config32' was here<br>
/home/corey/coreboot/coreboot-v2/src/arch/i386/include/arch/romcc_io.h:204: error: redefinition of 'pci_write_config8'<br>/home/corey/coreboot/coreboot-v2/src/southbridge/amd/amd8111/amd8111_reset.c:15: error: previous definition of 'pci_write_config8' was here<br>
/home/corey/coreboot/coreboot-v2/src/arch/i386/include/arch/romcc_io.h:266: error: redefinition of 'pci_write_config32'<br>/home/corey/coreboot/coreboot-v2/src/southbridge/amd/amd8111/amd8111_reset.c:23: error: previous definition of 'pci_write_config32' was here<br>
/home/corey/coreboot/coreboot-v2/src/arch/i386/include/arch/romcc_io.h:300: error: redefinition of 'pci_locate_device_on_bus'<br>/home/corey/coreboot/coreboot-v2/src/southbridge/amd/amd8111/amd8111_reset.c:40: error: previous definition of 'pci_locate_device_on_bus' was here<br>
make[1]: *** [amd8111_reset.o] Error 1<br><br>and asus a8n_e:<br><br>/home/corey/coreboot/coreboot-v2/src/arch/i386/include/arch/romcc_io.h:174: error: redefinition of 'pci_read_config32'<br>/home/corey/coreboot/coreboot-v2/src/southbridge/nvidia/ck804/ck804_reset.c:24: error: previous definition of 'pci_read_config32' was here<br>
/home/corey/coreboot/coreboot-v2/src/arch/i386/include/arch/romcc_io.h:266: error: redefinition of 'pci_write_config32'<br>/home/corey/coreboot/coreboot-v2/src/southbridge/nvidia/ck804/ck804_reset.c:16: error: previous definition of 'pci_write_config32' was here<br>
<br>The fix is probably as simple as multiple inclusion guards in the header files. I'd do it, but it's 4:30am here, I'm headed to bed. I'm also attaching the log of an abuild run with your patches and Carl-Daniel's applied, so everyone can see where we stand. Perhaps we should create a temporary wiki page with the list of broken targets in it, and check them off as they're fixed? Only downside being not everyone has wiki access...<br>
<br>-Corey<br></div></div>