<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
On 16.03.2009 23:50 Uhr, Peter Stuge wrote:
<blockquote cite="mid:20090316225027.1391.qmail@stuge.se" type="cite">
<pre wrap="">Stefan Reinauer wrote:
</pre>
<blockquote type="cite">
<pre wrap="">This patch adds "high coreboot table support" to coreboot version 2.
</pre>
</blockquote>
<pre wrap=""><!---->
I like it.
</pre>
<blockquote type="cite">
<pre wrap="">This patch also adds "table forward" support to flashrom and
nvramtool.
</pre>
</blockquote>
<pre wrap=""><!---->
The additions to flashrom aren't super clean. Please change the
variable name low_1MB now that it doesn't always map to the low 1MB.
Also please make the find_lb_table() call use the new #define instead
of hardcoded 1024*1024 since it was substituted everywhere else.
</pre>
<blockquote type="cite">
<pre wrap=""> if (!lb_table)
lb_table = find_lb_table(low_1MB, 0xf0000, 1024*1024);
</pre>
</blockquote>
<pre wrap=""><!---->
(This call.)
Please fix that, then it's:
Acked-by: Peter Stuge <a class="moz-txt-link-rfc2396E" href="mailto:peter@stuge.se"><peter@stuge.se></a>
</pre>
</blockquote>
Thanks a lot!<br>
<br>
Fixed the issues, and committed as 4011-4013<br>
<br>
<pre class="moz-signature" cols="72">--
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: <a class="moz-txt-link-abbreviated" href="mailto:info@coresystems.de">info@coresystems.de</a> • <a class="moz-txt-link-freetext" href="http://www.coresystems.de/">http://www.coresystems.de/</a>
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866
</pre>
</body>
</html>