<html>
<head>
<style>
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 10pt;
font-family:Verdana
}
</style>
</head>
<body class='hmmessage'>
I will have a vocation. I am gonna test next Thursday.<BR>
<BR>
Zheng<BR> <BR>> Date: Fri, 5 Jun 2009 12:51:46 +0200<BR>> From: c-d.hailfinger.devel.2006@gmx.net<BR>> To: coreboot@coreboot.org; Zheng.Bao@amd.com<BR>> Subject: [coreboot] [PATCH] Fix AMD 690 HIGH_TABLES<BR>> <BR>> Zheng, can you please test this with HIGH_TABLES enabled (and a new FILO)?<BR>> A full log would be appreciated. Thanks.<BR>> <BR>> This hopefully will fix AMD 690 HIGH_TABLES or at least give me an<BR>> insight into why HIGH_TABLES fails.<BR>> <BR>> Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net><BR>> <BR>> Index: LinuxBIOSv2-asus_m2a-vm/src/northbridge/amd/amdk8/northbridge.c<BR>> ===================================================================<BR>> --- LinuxBIOSv2-asus_m2a-vm/src/northbridge/amd/amdk8/northbridge.c (Revision 4339)<BR>> +++ LinuxBIOSv2-asus_m2a-vm/src/northbridge/amd/amdk8/northbridge.c (Arbeitskopie)<BR>> @@ -896,6 +896,7 @@<BR>> #if HAVE_HIGH_TABLES==1<BR>> #define HIGH_TABLES_SIZE 64 // maximum size of high tables in KB<BR>> extern uint64_t high_tables_base, high_tables_size;<BR>> +extern uint64_t uma_memory_base, uma_memory_size;<BR>> #endif<BR>> <BR>> static void pci_domain_set_resources(device_t dev)<BR>> @@ -1066,7 +1067,9 @@<BR>> }<BR>> <BR>> <BR>> -// printk_debug("node %d : mmio_basek=%08x, basek=%08x, limitk=%08x\n", i, mmio_basek, basek, limitk); //yhlu<BR>> + printk_debug("node %d : uma_memory_base/1024=0x%08x, mmio_basek=0x%08x, basek=0x%08x, limitk=0x%08x\n", i, uma_memory_base >> 10, mmio_basek, basek, limitk);<BR>> + if ((uma_memory_base >> 10) < mmio_basek)<BR>> + printk_alert("node %d: UMA memory starts below mmio_basek\n", i);<BR>> <BR>> /* See if I need to split the region to accomodate pci memory space */<BR>> if ( (basek < 4*1024*1024 ) && (limitk > mmio_basek) ) {<BR>> @@ -1080,7 +1083,7 @@<BR>> #if HAVE_HIGH_TABLES==1<BR>> if (i==0 && high_tables_base==0) {<BR>> /* Leave some space for ACPI, PIRQ and MP tables */<BR>> - high_tables_base = (mmio_basek - HIGH_TABLES_SIZE) * 1024;<BR>> + high_tables_base = ((uma_memory_base >> 10) - HIGH_TABLES_SIZE) * 1024;<BR>> high_tables_size = HIGH_TABLES_SIZE * 1024;<BR>> printk_debug("(split)%xK table at =%08llx\n", HIGH_TABLES_SIZE,<BR>> high_tables_base);<BR>> @@ -1105,6 +1108,9 @@<BR>> sizek -= (4*1024*1024 - mmio_basek);<BR>> }<BR>> }<BR>> +<BR>> + printk_debug("node %d : uma_memory_base/1024=0x%08x, mmio_basek=0x%08x, basek=0x%08x, limitk=0x%08x\n", i, uma_memory_base >> 10, mmio_basek, basek, limitk);<BR>> +<BR>> /* If sizek == 0, it was split at mmio_basek without a hole.<BR>> * Don't create an empty ram_resource.<BR>> */<BR>> @@ -1116,7 +1122,7 @@<BR>> i, mmio_basek, basek, limitk);<BR>> if (i==0 && high_tables_base==0) {<BR>> /* Leave some space for ACPI, PIRQ and MP tables */<BR>> - high_tables_base = (limitk - HIGH_TABLES_SIZE) * 1024;<BR>> + high_tables_base = ((uma_memory_base >> 10) - HIGH_TABLES_SIZE) * 1024;<BR>> high_tables_size = HIGH_TABLES_SIZE * 1024;<BR>> }<BR>> #endif<BR>> <BR>> <BR>> -- <BR>> http://www.hailfinger.org/<BR>> <BR><br /><hr />Windows Live™: Keep your life in sync. <a href='http://windowslive.com/explore?ocid=TXT_TAGLM_WL_t1_allup_explore_012009' target='_new'>Check it out!</a></body>
</html>