<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
On 09.06.2009 13:11 Uhr, ron minnich wrote:
<blockquote
cite="mid:13426df10906090411y23fceb6dpa8ed3b7aa62e7c79@mail.gmail.com"
type="cite">
<pre wrap="">On Mon, Jun 8, 2009 at 11:29 PM, Stefan Reinauer<a class="moz-txt-link-rfc2396E" href="mailto:stepan@coresystems.de"><stepan@coresystems.de></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">I hope we find out why this is a problem, because a combination of cli+sti
should never cause an interrupt that would not exist without cli+sti. If we
can't I suggest we commit this in a few days (Acked-by: Stefan Reinauer
<a class="moz-txt-link-rfc2396E" href="mailto:stepan@coresystems.de"><stepan@coresystems.de></a>) since it fixes the problem.
</pre>
</blockquote>
<pre wrap=""><!---->
I'm going to commit it. The reason is that we should never do an sti
unless we are prepared to take a device interrupt, and we are not. I
think it is an error to do an sti at this point. Also, just doing a
cli/sti without determining that interrupts were enabled in the first
place is also a mistake.
</pre>
</blockquote>
<br>
I agree. Sorry for the premature action of me adding cli/sti to my
original code submission. I only tested on real hardware (three boards,
all with the same chipset)... This is a good example how complex
interactions between components for seemingly trivial code can be. <br>
<br>
<br>
Stefan<br>
<br>
<br>
<pre class="moz-signature" cols="72">--
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: <a class="moz-txt-link-abbreviated" href="mailto:info@coresystems.de">info@coresystems.de</a> • <a class="moz-txt-link-freetext" href="http://www.coresystems.de/">http://www.coresystems.de/</a>
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866
</pre>
</body>
</html>