<br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
+#if CONFIG_GFXUMA == 1<br>
+ printk_debug("node %d : uma_memory_base/1024=0x%08x, mmio_basek=0x%08x, basek=0x%08x, limitk=0x%08x\n", i, uma_memory_base >> 10, mmio_basek, basek, limitk);<br>
+ if ((uma_memory_base >> 10) < mmio_basek)<br>
+ printk_alert("node %d: UMA memory starts below mmio_basek\n", i);<br></blockquote><div>Isn't this always true? It seems like if uma_memory_base > (mmio_basek - uma_memory_size) it's an error.<br>
<br>As a side note, I think that calculation should be done here, and I don't think it should depend on how much RAM is installed, but should be user configurable.<br><br>Then we can unify GFXUMA and VGA_MEM_MB -> UMA_MEM_MB. Then uma_memory_base can go away too, since it will be mmio_base - VGA_MEM_MB.<br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
+#else<br>
// printk_debug("node %d : mmio_basek=%08x, basek=%08x, limitk=%08x\n", i, mmio_basek, basek, limitk); //yhlu<br>
+#endif<br>
<br>
/* See if I need to split the region to accomodate pci memory space */<br>
if ( (basek < 4*1024*1024 ) && (limitk > mmio_basek) ) {<br>
@@ -1015,7 +1024,11 @@<br>
#if CONFIG_WRITE_HIGH_TABLES==1<br>
if (i==0 && high_tables_base==0) {<br>
/* Leave some space for ACPI, PIRQ and MP tables */<br>
+#if CONFIG_GFXUMA == 1<br>
+ high_tables_base = ((uma_memory_base >> 10) - HIGH_TABLES_SIZE) * </blockquote><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
1024;<br></blockquote><div>high_tables_base = uma_memory_base - (HIGH_TABLES_SIZE * 1024);<br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
+#else<br>
high_tables_base = (mmio_basek - HIGH_TABLES_SIZE) * 1024;<br></blockquote><div> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
@@ -1051,7 +1064,11 @@<br>
i, mmio_basek, basek, limitk);<br>
if (i==0 && high_tables_base==0)<br>
/* Leave some space for ACPI, PIRQ and MP tables */<br>
+#if CONFIG_GFXUMA == 1<br>
+ high_tables_base = ((uma_memory_base >> 10) - HIGH_TABLES_SIZE) * 1024;<br></blockquote><div>same thing.<br><br>Thanks,<br>Myles<br></div></div>