src/cpu/x86/smm/Makefile.inc:33: warning: overriding commands for target `/home/myles/try/buildrom-devel/work/coreboot/svn/build/cpu/x86/smm/smm.o'<br>src/cpu/x86/smm/Makefile.inc:33: warning: ignoring old commands for target `/home/myles/try/buildrom-devel/work/coreboot/svn/build/cpu/x86/smm/smm.o'<br>
src/cpu/x86/smm/Makefile.inc:36: warning: overriding commands for target `/home/myles/try/buildrom-devel/work/coreboot/svn/build/cpu/x86/smm/smm'<br>src/cpu/x86/smm/Makefile.inc:36: warning: ignoring old commands for target `/home/myles/try/buildrom-devel/work/coreboot/svn/build/cpu/x86/smm/smm'<br>
src/cpu/x86/smm/Makefile.inc:41: warning: overriding commands for target `/home/myles/try/buildrom-devel/work/coreboot/svn/build/cpu/x86/smm/smm_bin.c'<br>src/cpu/x86/smm/Makefile.inc:41: warning: ignoring old commands for target `/home/myles/try/buildrom-devel/work/coreboot/svn/build/cpu/x86/smm/smm_bin.c'<br>
<br>myles@orangutan:svn$ grep -Ir subdirs.*smm src/ | grep -v svn<br>src/cpu/x86/Makefile.inc:subdirs-y += smm<br>src/cpu/via/model_c7/Makefile.inc:subdirs-y += ../../x86/smm<br>src/cpu/via/model_c3/Makefile.inc:subdirs-y += ../../x86/smm<br>
src/cpu/intel/ep80579/Makefile.inc:subdirs-y += ../../x86/smm<br><br>First it gets included with src/cpu/x86, then with every cpu model.  Can we just remove those?<br><br>subdirs-y += amd<br>subdirs-y += intel<br>subdirs-y += via<br>
subdirs-y += emulation<br>subdirs-y += x86<br><br>This is a little strange, though.  All the rest are brands.<br><br>To be consistent, I think we should remove subdirs-y += x86 from src/cpu/Makefile.inc, and let every CPU include it.  Patch attached.<br>
<br>Signed-off-by: Myles Watson <<a href="mailto:mylesgw@gmail.com">mylesgw@gmail.com</a>><br><br>I'd be equally happy with every CPU (since we only have x86), just doing subdir-y += ../../x86 so they didn't have to be repeated.<br>
<br>Thanks,<br>Myles<br><br><br><br><br><br>