<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii">
<meta name=Generator content="Microsoft Word 11 (filtered medium)">
<!--[if !mso]>
<style>
v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style>
<![endif]-->
<style>
<!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman";}
a:link, span.MsoHyperlink
{color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{color:blue;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Courier New";
color:windowtext;
font-weight:normal;
font-style:normal;
text-decoration:none none;}
@page Section1
{size:8.5in 11.0in;
margin:1.0in 1.25in 1.0in 1.25in;}
div.Section1
{page:Section1;}
-->
</style>
</head>
<body lang=EN-US link=blue vlink=blue>
<div class=Section1>
<p class=MsoNormal><font size=2 face="Courier New"><span style='font-size:10.0pt;
font-family:"Courier New"'>R4954.<o:p></o:p></span></font></p>
<p class=MsoNormal><font size=2 face="Courier New"><span style='font-size:10.0pt;
font-family:"Courier New"'><o:p> </o:p></span></font></p>
<p class=MsoNormal><font size=2 face="Courier New"><span style='font-size:10.0pt;
font-family:"Courier New"'><o:p> </o:p></span></font></p>
<div>
<div class=MsoNormal align=center style='text-align:center'><font size=3
face="Times New Roman"><span style='font-size:12.0pt'>
<hr size=2 width="100%" align=center tabindex=-1>
</span></font></div>
<p class=MsoNormal><b><font size=2 face=Tahoma><span style='font-size:10.0pt;
font-family:Tahoma;font-weight:bold'>From:</span></font></b><font size=2
face=Tahoma><span style='font-size:10.0pt;font-family:Tahoma'> Libra Li
[mailto:librali1977@gmail.com] <br>
<b><span style='font-weight:bold'>Sent:</span></b> Wednesday, November 25, 2009
2:19 PM<br>
<b><span style='font-weight:bold'>To:</span></b> Bao, Zheng<br>
<b><span style='font-weight:bold'>Cc:</span></b> coreboot<br>
<b><span style='font-weight:bold'>Subject:</span></b> Re: [coreboot] [PATCH]
The buzzer of TechNexion TIM-5690.</span></font><o:p></o:p></p>
</div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'><o:p> </o:p></span></font></p>
<p class=MsoNormal style='margin-bottom:12.0pt'><font size=3
face="Times New Roman"><span style='font-size:12.0pt'>Hi, <br>
<br>
I had fixing non-ascii characters in the comments.<br>
Thanks.<br>
<br>
Signed-off: Libra Li <<a href="http://libra.li/"
target="_blank">libra.li</a>@<a href="http://technexion.com/" target="_blank">technexion.com</a>><br>
<br>
<o:p></o:p></span></font></p>
<div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'>2009/11/25 Bao, Zheng <<a href="mailto:Zheng.Bao@amd.com">Zheng.Bao@amd.com</a>><o:p></o:p></span></font></p>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'>I haven't apply your patch, but in your patch,<br>
line 140, 150, 159, 166, 175, 185, 194,<br>
have those chars.<br>
<br>
You can use the perl script to detect the non-ascii chars. I sense there should
be another better way.<br>
<br>
#!/usr/bin/perl<br>
<br>
my($content, $len);<br>
<br>
open(FILE, "< tim5690_buzzer_2.patch") || die "Unable to open
file small. <$!>\n";<br>
<br>
while( chomp($content = <FILE>) ) {<br>
$len = length($content);<br>
for( $i = 0; $i < $len; $i++ ) {<br>
if( ord(substr($content, $i, 1)) > 127 )<br>
{<br>
print "$content\n";<br>
last;<br>
}<br>
}<br>
}<br>
close(FILE);<br>
<br>
exit 0<br>
~<o:p></o:p></span></font></p>
<div>
<div>
<p class=MsoNormal style='margin-bottom:12.0pt'><font size=3
face="Times New Roman"><span style='font-size:12.0pt'><br>
<br>
<br>
<br>
-----Original Message-----<br>
From: <a href="mailto:coreboot-bounces@coreboot.org">coreboot-bounces@coreboot.org</a>
[mailto:<a href="mailto:coreboot-bounces@coreboot.org">coreboot-bounces@coreboot.org</a>]
On Behalf Of Bao, Zheng<br>
Sent: Wednesday, November 25, 2009 11:32 AM<br>
To: Libra Li<br>
Cc: coreboot<br>
Subject: Re: [coreboot] [PATCH] The buzzer of TechNexion TIM-5690.<br>
<br>
There is some non-ascii characters in the comments. Please fix it.<br>
After that,<br>
<br>
Acked-by: Zheng Bao <<a href="mailto:zheng.bao@amd.com">zheng.bao@amd.com</a>><br>
<br>
Zheng<br>
________________________________________<br>
From: <a href="mailto:coreboot-bounces@coreboot.org">coreboot-bounces@coreboot.org</a>
[mailto:<a href="mailto:coreboot-bounces@coreboot.org">coreboot-bounces@coreboot.org</a>]
On Behalf Of Libra Li<br>
Sent: Wednesday, November 25, 2009 9:46 AM<br>
To: Myles Watson<br>
Cc: coreboot<br>
Subject: Re: [coreboot] [PATCH] The buzzer of TechNexion TIM-5690.<br>
<br>
Hi, Myles, Coreboot,<br>
<br>
I had change EARLY_STAGE into __PRE_RAM__. It's okay.<br>
Thanks.<br>
<br>
Signed-off: Libra Li <<a href="http://libra.li"
target="_blank">libra.li</a>@<a href="http://technexion.com" target="_blank">technexion.com</a>><br>
<br>
2009/11/25 Myles Watson <<a href="mailto:mylesgw@gmail.com">mylesgw@gmail.com</a>><br>
2009/11/24 Libra Li <<a href="mailto:librali1977@gmail.com">librali1977@gmail.com</a>>:<br>
> Hi,<br>
><br>
> This patch is buzzer function of TechNexion TIM-5690.<br>
> That isn't everyone needs. So I don't put in public
areas.<br>
> Thanks.<br>
><br>
> Signed-off: Libra Li <<a href="http://libra.li"
target="_blank">libra.li</a>@<a href="http://technexion.com" target="_blank">technexion.com</a>><br>
Could you use __PRE_RAM__ instead of EARLY_STAGE? Does it mean<br>
something different?<br>
<br>
Thanks,<br>
Myles<br>
<br>
<br>
<o:p></o:p></span></font></p>
</div>
</div>
<p class=MsoNormal style='margin-bottom:12.0pt'><font size=3 color="#888888"
face="Times New Roman"><span style='font-size:12.0pt;color:#888888'>--<br>
coreboot mailing list: <a href="mailto:coreboot@coreboot.org">coreboot@coreboot.org</a><br>
<a href="http://www.coreboot.org/mailman/listinfo/coreboot" target="_blank">http://www.coreboot.org/mailman/listinfo/coreboot</a><br>
<br>
</span></font><o:p></o:p></p>
</div>
<p class=MsoNormal><font size=3 face="Times New Roman"><span style='font-size:
12.0pt'><o:p> </o:p></span></font></p>
</div>
</body>
</html>