<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<title></title>
</head>
<body bgcolor="#ffffff" text="#000000">
On 1/23/10 5:43 PM, Samuel D. wrote:
<blockquote cite="mid:003901ca9c4b$42c49460$c84dbd20$@com" type="cite">
<meta http-equiv="Content-Type"
content="text/html; charset=ISO-8859-1">
<meta name="Generator" content="Microsoft Word 12 (filtered medium)">
<style>
<!--
/* Font Definitions */
@font-face
{font-family:Helvetica;
panose-1:2 11 6 4 2 2 2 2 2 4;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"Préformaté HTML Car";
margin:0cm;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;}
span.PrformatHTMLCar
{mso-style-name:"Préformaté HTML Car";
mso-style-priority:99;
mso-style-link:"Préformaté HTML";
font-family:Consolas;
color:black;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page Section1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 70.85pt 70.85pt;}
div.Section1
{page:Section1;}
-->
</style>
<!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="Section1">
<p class="MsoNormal"><span
style="font-size: 11pt; font-family: "Calibri","sans-serif"; color: rgb(31, 73, 125);"
lang="EN-US">I don't have any way to test this patch right now, so
I'll just
add it in upcoming 4.01.<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size: 11pt; font-family: "Calibri","sans-serif"; color: rgb(31, 73, 125);"
lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size: 11pt; font-family: "Calibri","sans-serif"; color: rgb(31, 73, 125);"
lang="EN-US">Thanks for your work.<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size: 11pt; font-family: "Calibri","sans-serif"; color: rgb(31, 73, 125);"
lang="EN-US"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size: 11pt; font-family: "Calibri","sans-serif"; color: rgb(31, 73, 125);"
lang="EN-US">Sam.</span></p>
</div>
</blockquote>
<small><font face="Helvetica, Arial, sans-serif"><br>
Dear Sam,<br>
<br>
there was an additional bug I introduced. On top of the other patch,
you need to apply this:</font></small><br>
<b><small><font face="Courier New, Courier, monospace"><br>
Index: coreboot.c<br>
===================================================================<br>
--- coreboot.c (revision 2775)<br>
+++ coreboot.c (working copy)<br>
@@ -123,7 +123,8 @@<br>
/* if there is, all valid information is in the <br>
* referenced coreboot table<br>
*/<br>
- head = __find_cb_table(forward->forward, 0x1000);<br>
+ head = __find_cb_table(forward->forward, <br>
+ forward->forward + 0x1000);<br>
}<br>
<br>
return head;<br>
</font></small></b><small><br>
</small><small><font face="Helvetica, Arial, sans-serif">In addition I
suggest to add the following patch:<br>
<br>
</font></small><font face="Helvetica, Arial, sans-serif"><b><font
face="Courier New, Courier, monospace"><small>Index: memsize.c<br>
===================================================================<br>
--- memsize.c (revision 2775)<br>
+++ memsize.c (working copy)<br>
@@ -125,7 +125,7 @@<br>
n++;<br>
}<br>
v->msegs = n;<br>
- cprint(LINE_INFO, COL_MMAP, "corebt");<br>
+ cprint(LINE_INFO, COL_MMAP, "coreboot");<br>
}<br>
static void memsize_820()<br>
{</small></font></b><br>
</font><br>
<small><font face="Helvetica, Arial, sans-serif">The other memory table
types only output 6 characters here, but the field is 8 characters, so
no need to abbreviate.<br>
Sorry I didn't notice this earlier.<br>
<br>
Best regards,<br>
Stefan</font></small><br>
<br>
<pre class="moz-signature" cols="72">--
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: <a class="moz-txt-link-abbreviated" href="mailto:info@coresystems.de">info@coresystems.de</a> • <a class="moz-txt-link-freetext" href="http://www.coresystems.de/">http://www.coresystems.de/</a>
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866
</pre>
</body>
</html>