<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#ffffff">
On 1/29/10 9:16 PM, Myles Watson wrote:
<blockquote cite="mid:638F172FF8684294B77AD6F3CF7954D7@chimp"
type="cite">
<meta http-equiv="Content-Type"
content="text/html; charset=ISO-8859-1">
<meta name="Generator" content="Microsoft Word 11 (filtered medium)">
<!--[if !mso]>
<style>
v\:* {behavior:url(#default#VML);}
o\:* {behavior:url(#default#VML);}
w\:* {behavior:url(#default#VML);}
.shape {behavior:url(#default#VML);}
</style>
<![endif]-->
<style>
<!--
/* Font Definitions */
@font-face
{font-family:Helvetica;
panose-1:2 11 6 4 2 2 2 3 2 4;}
@font-face
{font-family:Times;
panose-1:2 2 6 3 6 4 5 2 3 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman";
color:black;}
span.MsoEndnoteReference
{vertical-align:super;}
a:link, span.MsoHyperlink
{color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{color:purple;
text-decoration:underline;}
span.MyRef
{font-family:Times;
font-weight:bold;
font-style:italic;
vertical-align:super;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:Arial;
color:navy;}
@page Section1
{size:8.5in 11.0in;
margin:1.0in 1.25in 1.0in 1.25in;}
div.Section1
{page:Section1;}
-->
</style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="Section1">
<p class="MsoNormal"><font face="Arial" size="2" color="navy"><span
style="font-size: 10pt; font-family: Arial; color: navy;">> * don't
turn on WARNINGS_AS_ERRORS
for Qemu per default<o:p></o:p></span></font></p>
<p class="MsoNormal"><font face="Arial" size="2" color="navy"><span
style="font-size: 10pt; font-family: Arial; color: navy;"><o:p> </o:p></span></font></p>
<p class="MsoNormal"><font face="Arial" size="2" color="navy"><span
style="font-size: 10pt; font-family: Arial; color: navy;">I disagree
with this change. I think it
should be noticed when changes add warnings to a target that is free of
them.
I think the goal should be to be able to turn this on for all targets.
There
have been several times that warnings pointed out breakage. Ignoring
them
seems counterproductive.<o:p></o:p></span></font></p>
<p class="MsoNormal"><font face="Arial" size="2" color="navy"><span
style="font-size: 10pt; font-family: Arial; color: navy;"><o:p> </o:p></span></font></p>
</div>
</blockquote>
Hm... It did not compile without warnings for me when I tried, so
that's why I disabled it at some point.<br>
<br>
I generally agree with what you're saying. Actually I manually deleted
the "add -Werror-implicit-function-declaration to CFLAGS" part of my
patch because I figured people would feel no love for me if I left it
in. I think it should go in then, too.<br>
<br>
Stefan<br>
<br>
<br>
</body>
</html>