<br><br><div class="gmail_quote">On Fri, Feb 26, 2010 at 3:38 PM, Patrick Georgi <span dir="ltr"><<a href="mailto:patrick@georgi-clan.de">patrick@georgi-clan.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi,<br>
<br>
after moving crt0s and lscripts away from the mainboards' Makefiles,<br>
those Makefiles are rather simple now, with more opportunities to move<br>
out things.<br>
<br>
Attached patch does:<br>
- make HAVE_HARD_RESET match what newconfig did<br>
- introduce BOARD_HAS_HARD_RESET and use it if a board provides<br>
hard_reset in $(MAINBOARDDIR)/reset.c, instead of some chipset component<br>
- move a couple of rules out of the mainboards' Makefiles into<br>
src/arch/i386/Makefile.inc:<br>
initobj-y += crt0.o<br>
obj-y += mainboard.o<br>
obj-$(CONFIG_GENERATE_MP_TABLE) += mptable.o<br>
obj-$(CONFIG_GENERATE_PIRQ_TABLE) += irq_tables.o<br>
obj-$(CONFIG_BOARD_HAS_HARD_RESET) += reset.o<br>
- remove Makefile.incs that are empty (or comment-only) after these<br>
changes, incl. Makefile.romccboard.inc (and references to it)<br>
- Make include not fail if file doesn't exist.<br>
<br>
reset.o used to be HAVE_HARD_RESET, but to make this rule more<br>
universal, that new variable had to be introduced.<br></blockquote><div>Can we put HAVE_HARD_RESET into the ck804 Kconfig instead of into all the ck804 mainboards?<br> <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
It's build tested and has no regression vs. current HEAD (ie. the same<br>
two boards fail for the same reason) and is boot tested on kontron/986lcd-m.<br>
<br>
Signed-off-by: Patrick Georgi <<a href="mailto:patrick.georgi@coresystems.de">patrick.georgi@coresystems.de</a>><br></blockquote><div>Acked-by: Myles Watson <<a href="mailto:mylesgw@gmail.com">mylesgw@gmail.com</a>><br>
<br>Thanks,<br>Myles <br></div></div><br>