<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#ffffff">
On 3/5/10 4:13 PM, Myles Watson wrote:<br>
<blockquote
cite="mid:2831fecf1003050713h77bd7abbx245a8bd6fa96a595@mail.gmail.com"
type="cite">
<div class="gmail_quote">
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">I
think we should get rid of that warning, since we conditionally call
functions based on debugging and various config variables. </blockquote>
</div>
</blockquote>
I think we should instead just drop CONFIG_WARNINGS_ARE_ERRORS for Qemu
rather than dropping warnings. Or maybe only add -Wno-unused-function
if CONFIG_WARNINGS_ARE_ERRORS is active, at least. Or maybe add an
Option "Warnings good for Developers"?<br>
<br>
<blockquote
cite="mid:2831fecf1003050713h77bd7abbx245a8bd6fa96a595@mail.gmail.com"
type="cite">
<div class="gmail_quote">
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Is
there a case where it helps enough to justify all the warnings?<br>
</blockquote>
</div>
</blockquote>
<br>
Yes, they indicate that there is dead code. This is, not only but
especially useful to recognize if / how code should / could be
restructured.<br>
<br>
<blockquote
cite="mid:2831fecf1003050713h77bd7abbx245a8bd6fa96a595@mail.gmail.com"
type="cite">
<div class="gmail_quote">
<div> Signed-off-by: Myles Watson <<a moz-do-not-send="true"
href="mailto:mylesgw@gmail.com" target="_blank">mylesgw@gmail.com</a>><br>
</div>
</div>
</blockquote>
With the -Wno-unused-functions taken care of:<br>
<br>
Acked-by: Stefan Reinauer <a class="moz-txt-link-rfc2396E" href="mailto:stepan@coresystems.de"><stepan@coresystems.de></a><br>
</body>
</html>