<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
On 3/25/10 11:46 PM, Stefan Reinauer wrote:
<blockquote cite="mid:4BABE7AF.5000702@coresystems.de" type="cite">
<pre wrap="">On 3/25/10 11:07 PM, Myles Watson wrote:
</pre>
<blockquote type="cite">
<blockquote type="cite">
<pre wrap="">@@ -273,8 +273,10 @@
acpi_create_facs(facs);
dsdt = (acpi_header_t *) current;
- current += AmlCode.length;
- memcpy((void *) dsdt, &AmlCode, AmlCode.length);
+ memcpy((void *) dsdt, AmlCode, sizeof(acpi_header_t));
+ int len = dsdt->length;
+ current += len;
+ memcpy((void *) dsdt, AmlCode, len);
</pre>
</blockquote>
<pre wrap="">Why not:
</pre>
<blockquote type="cite">
<pre wrap="">+ current += dstd->length;
+ memcpy((void *) dsdt, AmlCode, dsdt->length);
</pre>
</blockquote>
<pre wrap="">I don't think the extra variable adds anything.
I'll ack that.
</pre>
</blockquote>
<pre wrap="">This is not all boards yet, but I send them out so I can go to bed :-)
</pre>
</blockquote>
<font size="-1"><font face="Helvetica, Arial, sans-serif"><br>
ping<br>
</font></font>
</body>
</html>