<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
On 3/30/10 12:43 AM, Myles Watson wrote:
<blockquote
cite="mid:2831fecf1003291543u24f37backc18a0c5ed9cb4e37@mail.gmail.com"
type="cite"><br>
<br>
<div class="gmail_quote">On Mon, Mar 29, 2010 at 4:40 PM, Stefan
Reinauer <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:stepan@coresystems.de">stepan@coresystems.de</a>></span>
wrote:<br>
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div bgcolor="#ffffff" text="#000000">
<div class="im">On 3/30/10 12:35 AM, Stefan Reinauer wrote:
<blockquote type="cite"> On 3/30/10 12:15 AM, Myles Watson wrote:<br>
<br>
<blockquote type="cite">
<div class="gmail_quote">
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Modified:
trunk/src/arch/i386/include/arch/pirq_routing.h<br>
==============================================================================<br>
--- trunk/src/arch/i386/include/arch/pirq_routing.h Mon Mar 29
23:56:26 2010 (r5318)<br>
+++ trunk/src/arch/i386/include/arch/pirq_routing.h Tue Mar 30
00:05:26 2010 (r5319)<br>
@@ -18,9 +18,8 @@<br>
<br>
#if defined(CONFIG_IRQ_SLOT_COUNT)<br>
#define IRQ_SLOTS_COUNT CONFIG_IRQ_SLOT_COUNT<br>
-#elif (__GNUC__ < 3)<br>
-#define IRQ_SLOTS_COUNT 1<br>
#else<br>
+#warning "No IRQ_SLOT_COUNT in Kconfig."<br>
#define IRQ_SLOTS_COUNT<br>
#endif<br>
<font color="#888888"><br>
</font></blockquote>
<div>I think we should get rid of IRQ_SLOTS_COUNT and move the
error
into Kconfig. The added warning is very similar to one in
pirq_routing.c<br>
</div>
</div>
</blockquote>
<br>
I like that much better... do you have a patch in mind?<br>
</blockquote>
<br>
</div>
Hm.. how do we error in Kconfig? Is there a way to do that at all? I
think we didn't use this before...<br>
</div>
</blockquote>
<div>I was thinking about making HAVE_PIRQ_TABLE depend on
CONFIG_IRQ_SLOT_COUNT<br>
<br>
Then when someone ported Coreboot to a board they'd set it correctly.
We could tell from abuild results how many boards have HAVE_PIRQ_TABLE
set and not CONFIG_IRQ_SLOT_COUNT.<br>
</div>
</div>
</blockquote>
<br>
I'd prefer the build failing if someone sets HAVE_PIRQ_TABLE without
CONFIG_IRQ_SLOT_COUNT (unless we can create CONFIG_IRQ_SLOT_COUNT on
the fly which would be much, much better)<br>
<br>
Silently disable HAVE_PIRQ_TABLE if CONFIG_IRQ_SLOT_COUNT is not there
would maybe lead to people enabling HAVE_PIRQ_TABLE and wondering or
not (more likely not) why there is no PIRQ table. At least on ACPI
systems, PIRQ is the untested path anyways..<br>
<br>
Stefan<br>
<br>
<pre class="moz-signature" cols="72">--
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: <a class="moz-txt-link-abbreviated" href="mailto:info@coresystems.de">info@coresystems.de</a> • <a class="moz-txt-link-freetext" href="http://www.coresystems.de/">http://www.coresystems.de/</a>
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866
</pre>
</body>
</html>