<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
On 4/2/10 7:55 PM, Myles Watson wrote:<br>
<blockquote
cite="mid:w2z2831fecf1004021055r600ac38av504270fa3fa4a481@mail.gmail.com"
type="cite">loglevel.diff:<br>
Remove BIOS_EMERG, BIOS_ALERT, BIOS_CRIT, BIOS_NOTICE, BIOS_NEVER<br>
</blockquote>
I am not convinced that's a good idea. But let's hear what other people
say...<br>
<blockquote
cite="mid:w2z2831fecf1004021055r600ac38av504270fa3fa4a481@mail.gmail.com"
type="cite">I didn't change their numerical values. They were rarely
used. <br>
BIOS_EMERG, BIOS_ALERT, BIOS_CRIT -> BIOS_ERR<br>
BIOS_NOTICE -> BIOS_INFO<br>
</blockquote>
I don't think we want to just remove log levels like that. Let's rather
fix the messages and choose the right log levels for them.<br>
<br>
<blockquote
cite="mid:w2z2831fecf1004021055r600ac38av504270fa3fa4a481@mail.gmail.com"
type="cite">BIOS_NEVER -> BIOS_SPEW+1<br>
</blockquote>
The whole intent was to make clear to the reader that this is something
that's never seen. ;-)<br>
That doesn't become clear from BIOS_SPEW+1 in my opinion.<br>
<br>
<br>
<blockquote
cite="mid:w2z2831fecf1004021055r600ac38av504270fa3fa4a481@mail.gmail.com"
type="cite">loglevel2.diff:<br>
BIOS_ERR -> ERROR<br>
BIOS_WARNING -> WARNING<br>
BIOS_INFO -> INFO<br>
BIOS_DEBUG -> DEBUG<br>
BIOS_SPEW -> SPEW<br>
For 80 character line aficionados, this puts most of the lines back,
since printk_debug(...) is about the same length as printk(DEBUG, ...)<br>
</blockquote>
I kind of like the fact that they are prefixed, while I see the point
that BIOS_ is a bad prefix. What about LOG_? Because, that's what it
is, log levels<small>.</small><br>
I like the idea of not abbreviating ERROR to ERR as the only exception
to the rule.<br>
<br>
Stefan
</body>
</html>