<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
On 4/14/10 9:35 PM, Myles Watson wrote:
<blockquote
cite="mid:u2p2831fecf1004141235zc8d1f89dja1eb1929a5faec1c@mail.gmail.com"
type="cite"><br>
<br>
<div class="gmail_quote">On Wed, Apr 14, 2010 at 1:22 PM, Stefan
Reinauer <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:stepan@coresystems.de">stepan@coresystems.de</a>></span>
wrote:<br>
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<div bgcolor="#ffffff" text="#000000">
<div>
<div class="h5">On 4/14/10 6:44 PM, Myles Watson wrote:
<blockquote type="cite"><br>
<div class="gmail_quote">
<blockquote class="gmail_quote"
style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Index:
src/northbridge/amd/gx2/chipsetinit.c<br>
===================================================================<br>
--- src/northbridge/amd/gx2/chipsetinit.c (revision 5425)<br>
+++ src/northbridge/amd/gx2/chipsetinit.c (working copy)<br>
@@ -275,7 +275,7 @@<br>
if ((msr.lo&0xff) == 0x11)<br>
return;<br>
<br>
- totalmem = sizeram() << 20 - 1;<br>
+ totalmem = (sizeram() << 20) - 1;<br>
</blockquote>
<div>I agree that it looks right, but it changes the answer,
since
subtraction has a higher precedence than shift.<br>
<br>
I don't have a board to test which is right. Did you check v3?<br>
</div>
</div>
</blockquote>
</div>
</div>
Nor do I...<br>
<br>
v3 never supported gx2.</div>
</blockquote>
</div>
<br>
I guess this should be the patch, then:<br>
<br>
- totalmem = sizeram() << 20 - 1;<br>
+ totalmem = sizeram() << (20 - 1);<br>
</blockquote>
If we can't decide on the right fix we should leave the warning there
as it keeps the question open until someone can answer it.<br>
<br>
<br>
</body>
</html>