<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
On 4/30/10 7:13 PM, Myles Watson wrote:
<blockquote
cite="mid:x2l2831fecf1004301013l39992ce9r263e935aa2d5270f@mail.gmail.com"
type="cite">
<pre wrap="">As of 5512, these are the last four warnings that are not "defined but
not used" warnings.
</pre>
</blockquote>
What's your impression... should we activate -Wno-unused ? or should we
attempt to fix them?<br>
<br>
I'd like to go drop all / most of the #ifdef UNUSED_CODE segments from
coreboot over time, making it easier to follow the code that is
actually there.<br>
<br>
Most of the existing warnings are amd k8 / fam10 warnings... and it's
kind of tricky to understand why one board does init different than
another one. Why don't all boards use "
<meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
wait_all_aps_started" and / or "
<meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
wait_all_core0_started" and / or
<meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
"allow_all_aps_stop"? I think the unused messages show that we have too
much unnecessary diversity here (aka rank growth)<br>
<blockquote
cite="mid:x2l2831fecf1004301013l39992ce9r263e935aa2d5270f@mail.gmail.com"
type="cite">
<pre wrap="">
src/northbridge/amd/gx2/chipsetinit.c:271: warning: suggest
parentheses around '-' inside '<<'
</pre>
</blockquote>
This would need help from someone with a GX2 (or willing to check out
the data sheets ;-)<br>
<br>
<blockquote
cite="mid:x2l2831fecf1004301013l39992ce9r263e935aa2d5270f@mail.gmail.com"
type="cite">
<pre wrap="">src/northbridge/amd/lx/raminit.c:334: warning: array subscript is
above array bounds
</pre>
</blockquote>
Marc indicated, this could be a compiler "problem". We could maybe add
an explicit check for the array index.<br>
<br>
<blockquote
cite="mid:x2l2831fecf1004301013l39992ce9r263e935aa2d5270f@mail.gmail.com"
type="cite">
<pre wrap="">src/northbridge/via/vx800/pci_rawops.h:43:2: warning: #warning "FIXME:
get rid of this extra copy of pci access functions."
</pre>
</blockquote>
<br>
Gone with 5513<br>
<br>
<blockquote
cite="mid:x2l2831fecf1004301013l39992ce9r263e935aa2d5270f@mail.gmail.com"
type="cite">
<pre wrap="">src/southbridge/intel/pxhd/pxhd_bridge.c:70:2: warning: #warning
"Please review lots of dead code here."
</pre>
</blockquote>
Gone with 5514<br>
<br>
<br>
<br>
<pre class="moz-signature" cols="72">--
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: <a class="moz-txt-link-abbreviated" href="mailto:info@coresystems.de">info@coresystems.de</a> • <a class="moz-txt-link-freetext" href="http://www.coresystems.de/">http://www.coresystems.de/</a>
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866
</pre>
</body>
</html>