<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-2"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#ffffff">
On 5/16/10 6:46 PM, Rudolf Marek wrote:
<blockquote cite="mid:4BF0216A.70706@assembler.cz" type="cite">
<table class="header-part1" width="100%" border="0" cellpadding="0"
cellspacing="0">
</table>
<br>
<div class="moz-text-plain" wrap="true" graphical-quote="true"
style="font-family: -moz-fixed; font-size: 13px;" lang="x-central-euro">
<pre wrap="">OpenPGP: <b class="moz-txt-star"><span
class="moz-txt-tag">*</span>Attachments to this message have not been signed or encrypted<span
class="moz-txt-tag">*</span></b>
********* <b class="moz-txt-star"><span class="moz-txt-tag">*</span>BEGIN ENCRYPTED or SIGNED PART<span
class="moz-txt-tag">*</span></b> *********
Hello,
Following patch reworks car_disable into C. Tested, works here. I compared
also the GCC generated code and it looks all right. Please test on some
multicore CPU.
</pre>
</div>
</blockquote>
<br>
A potential Todo on my list was to straighten out cache_as_ram on
K8/K10 in the same way as we did on all the other functions, and that
would mean calling post_cache_as_ram() from assembler directly, so we
don't have to add the call to each and every romstage.c:main()
function. That might<br>
include a second jump to a C function, or significantly stripping down
post_cache_as_ram() for those CPUs so it can easily be added in
assembler like on the other CPUs. What do you think?<br>
<br>
<blockquote cite="mid:4BF0216A.70706@assembler.cz" type="cite">
<div class="moz-text-plain" wrap="true" graphical-quote="true"
style="font-family: -moz-fixed; font-size: 13px;" lang="x-central-euro">
<pre wrap="">
I added the "memory" clobber to read_cr0 / write_cr0 function as it is in Linux
Kernel. Seems that if this is missing, GCC is too smart and messes the order
of reads/writes to CR0 (not tested if really a problem here, but be safe for
future users of this function <span class="moz-smiley-s3" title=";)"><span>;)</span></span>
Signed-off-by: Rudolf Marek <a moz-do-not-send="true"
class="moz-txt-link-rfc2396E" href="mailto:r.marek@assembler.cz"><r.marek@assembler.cz></a>
</pre>
</div>
</blockquote>
<br>
Acked-by: Stefan Reinauer <a class="moz-txt-link-rfc2396E" href="mailto:stepan@coresystems.de"><stepan@coresystems.de></a><br>
<blockquote cite="mid:4BF0216A.70706@assembler.cz" type="cite">
<div class="moz-text-plain" wrap="true" graphical-quote="true"
style="font-family: -moz-fixed; font-size: 13px;" lang="x-central-euro">
<pre wrap="">
Maybe we can add nice copyright header too?
</pre>
</div>
</blockquote>
Please do!<br>
<br>
<br>
<br>
<pre class="moz-signature" cols="72">--
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: <a class="moz-txt-link-abbreviated" href="mailto:info@coresystems.de">info@coresystems.de</a> • <a class="moz-txt-link-freetext" href="http://www.coresystems.de/">http://www.coresystems.de/</a>
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866
</pre>
</body>
</html>