<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
On 8/16/10 5:11 PM, Myles Watson wrote:
<blockquote
cite="mid:AANLkTi=G0_HjgVg7FTofRLqAyR7pL4t6X4Q7q7iyq0cz@mail.gmail.com"
type="cite">
<div class="moz-text-plain" wrap="true" graphical-quote="true"
style="font-family: -moz-fixed; font-size: 12px;"
lang="x-western">
<pre wrap="">I think that the value that was left out of devicetree.cb should move
to the mainboard init() or into the device that's being configured
(cs5536.) It makes sense to use values in the device tree to
parameterize device code for specific mainboards, but I don't see the
point of parameterizing mainboard-specific code from the device tree.
Thanks,
Myles
</pre>
</div>
</blockquote>
<blockquote
cite="mid:AANLkTi=G0_HjgVg7FTofRLqAyR7pL4t6X4Q7q7iyq0cz@mail.gmail.com"
type="cite">
<div class="moz-text-plain" wrap="true" graphical-quote="true"
style="font-family: -moz-fixed; font-size: 12px;"
lang="x-western">
<pre wrap="">Index: src/devices/device.c
===================================================================
--- src/devices/device.c (revision 5692)
+++ src/devices/device.c (working copy)
@@ -1104,6 +1104,9 @@
printk(BIOS_INFO, "Initializing devices...\n");
+ /* First call the mainboard init. */
+ init_dev(&dev_root);
+
/* now initialize everything. */
for (link = dev_root.link_list; link; link = link->next)
init_link(link);
</pre>
</div>
</blockquote>
<br>
Acked-by: Stefan Reinauer <a class="moz-txt-link-rfc2396E" href="mailto:stepan@coresystems.de"><stepan@coresystems.de></a><br>
<br>
Thanks for fixing coreboot. mainboard specific setup code is
critical for many boards.<br>
<br>
Stefan<br>
</body>
</html>