hi stepan,<br> thanks for your kindly help about the code reviewing. I did a new patch which followed by your suggestion.<br>the new patch also added the function to avoid RS780 PCI emulation problems.<br>I also attached the log which booting SUSE 11.2 with coreboot. The payload is Seabios. <br>
<br><div class="gmail_quote">On Sun, Aug 15, 2010 at 7:51 PM, Stefan Reinauer <span dir="ltr"><<a href="mailto:stefan.reinauer@coresystems.de" target="_blank">stefan.reinauer@coresystems.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div bgcolor="#ffffff" text="#000000"><div><div></div><div>
On 8/13/10 9:50 AM, Qing Pei Wang wrote:
<blockquote type="cite">hi,<br>
the attach file added the support of Gigabyte MA785GMT
mainboard.<br>
the details of the hardware configuration can be found at<br>
<a href="http://www.gigabyte.com/products/product-page.aspx?pid=3478" target="_blank">http://www.gigabyte.com/products/product-page.aspx?pid=3478</a>
<br>
a breif configuration is:<br>
1. CPU:Support for AM3 processors: AMD PhenomTM II processor/ AMD
Athlon™ II processor<br>
2. North Bridge: AMD 785G<br>
3. South Bridge: AMD SB710 <br>
4: Super IO : ITE8718F<br clear="all">
<br>
The mainboard has two bios flashchip. Coreboot ROM should be
flashed into the M_BIOS(which means main bios).<br>
signed-off-by Wang Qing Pei <<a href="mailto:wangqingpei@gmail.com" target="_blank">wangqingpei@gmail.com</a>><br>
</blockquote>
<br></div></div>
Hi Qing Pei!<br>
<br>
Thanks for this patch! It's great to have more boards in the tree.<br>
<br>
<blockquote type="cite">---
src/mainboard/gigabyte/ma785gmt/mb_sysconf.h (revision 0)<br>
+++ src/mainboard/gigabyte/ma785gmt/mb_sysconf.h (revision
0)<br>
<br>
</blockquote>
..<br>
<blockquote type="cite">+#ifndef MB_SYSCONF_H<br>
+<br>
+#define MB_SYSCONF_H<br>
+<br>
+struct mb_sysconf_t {<br>
+ u8 bus_isa;<br>
+ u8 bus_8132_0;<br>
+ u8 bus_8132_1;<br>
+ u8 bus_8132_2;<br>
+ u8 bus_8111_0;<br>
+ u8 bus_8111_1;<br>
+ u8 bus_8132a[31][3];<br>
+ u8 bus_8151[31][2];<br>
+<br>
+ u32 apicid_8111;<br>
+ u32 apicid_8132_1;<br>
+ u32 apicid_8132_2;<br>
+ u32 apicid_8132a[31][2];<br>
+ u32 sbdn3;<br>
+ u32 sbdn3a[31];<br>
+ u32 sbdn5[31];<br>
+ u32 bus_type[256];<br>
+};<br>
+<br>
+#endif<br>
</blockquote>
Can you check if this file is really needed?<br>
<br>
I would expect that anything that references AMD8132, AMD8111 and
AMD8151 is not needed on an AMD785/SB710 board?<br>
<br>
Also, a lot of files in the patch are exact copies of the AMD
Tilapia board. I counted 15 files where the only change from Tilapia
is the following:<br>
<br>
<blockquote type="cite">@@ -1,7 +1,7 @@<br>
/*<br>
* This file is part of the coreboot project.<br>
- * Copyright (C) 2010 Advanced Micro Devices, Inc.<br>
+ * Copyright (C) 2010 Wang Qing Pei <a href="mailto:wangqingpei@gmail.com" target="_blank"><wangqingpei@gmail.com></a><br>
*<br>
* This program is free software; you can redistribute it and/or
modify<br>
* it under the terms of the GNU General Public License as
published by<br>
</blockquote>
<br>
Some more change the name from AMD Tilapia to Gigabyte GA785GMT in
addition to that.<br>
<br>
Those files should keep the AMD copyright in there I believe. The
ones that you didn't change should not have your copyright added.<br>
<br>
I think with above issues adressed we could commit this patch.<br>
<br>
Thanks,<br>
<br>
Stefan<br>
<br>
<br>
</div>
<br>--<br>
coreboot mailing list: <a href="mailto:coreboot@coreboot.org" target="_blank">coreboot@coreboot.org</a><br>
<a href="http://www.coreboot.org/mailman/listinfo/coreboot" target="_blank">http://www.coreboot.org/mailman/listinfo/coreboot</a><br></blockquote></div><br><br clear="all"><br>-- <br>Wang Qing Pei <br>Phone: 86+13426369984<br>