<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-15"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
On 9/25/10 1:52 PM, Patrick Georgi wrote:
<blockquote cite="mid:4C9DE267.5090308@georgi-clan.de" type="cite">
<div class="moz-text-plain" wrap="true" graphical-quote="true"
style="font-family: -moz-fixed; font-size: 12px;"
lang="x-western">
<pre wrap="">attached patch makes globals in romstage a build breaking condition,
given that .bss and .data are allocated in ROM areas (ie. non-writable)
this is provides some protection against certain coding errors.
Signed-off-by: Patrick Georgi <a moz-do-not-send="true" class="moz-txt-link-rfc2396E" href="mailto:patrick.georgi@coresystems.de"><patrick.georgi@coresystems.de></a>
</pre>
</div>
</blockquote>
Acked-by: Stefan Reinauer <a class="moz-txt-link-rfc2396E" href="mailto:stepan@coresystems.de"><stepan@coresystems.de></a><br>
<br>
<blockquote cite="mid:4C9DE267.5090308@georgi-clan.de" type="cite">
<div class="moz-text-plain" wrap="true" graphical-quote="true"
style="font-family: -moz-fixed; font-size: 12px;"
lang="x-western">
<pre wrap="">Index: src/arch/i386/init/ldscript_fallback_cbfs.lb
===================================================================
--- src/arch/i386/init/ldscript_fallback_cbfs.lb (Revision 5839)
+++ src/arch/i386/init/ldscript_fallback_cbfs.lb (Arbeitskopie)
@@ -49,4 +49,5 @@
*(.comment.*)
*(.note.*)
}
+ _bogus = ASSERT((SIZEOF(.bss) + SIZEOF(.data)) == 0, "Do not use global variables in romstage");
}
</pre>
</div>
</blockquote>
<br>
</body>
</html>