<div dir="ltr">I took a look. I don't consider myself qualified to +2 but I added reviewers who should be able to.</div><br><div class="gmail_quote"><div dir="ltr">On Thu, Dec 29, 2016 at 4:50 AM Agrain Patrick <<a href="mailto:patrick.agrain@al-enterprise.com">patrick.agrain@al-enterprise.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple" class="gmail_msg">
<div class="m_7400901810251125195WordSection1 gmail_msg">
<p class="MsoNormal gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" class="gmail_msg">Hello all,<u class="gmail_msg"></u><u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" class="gmail_msg"><u class="gmail_msg"></u> <u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" class="gmail_msg">I’ve pushed the code to support the EXAR SuperIO XR28V382.<u class="gmail_msg"></u><u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" class="gmail_msg">It is marked “[WIP]” with “XR28V382” in the title.<u class="gmail_msg"></u><u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" class="gmail_msg"><u class="gmail_msg"></u> <u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" class="gmail_msg">Can anybody have a look at it and meaby point me to a bug, missing configuration or other… that could explain the messages on the console displayed below ?<u class="gmail_msg"></u><u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" class="gmail_msg"><u class="gmail_msg"></u> <u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" class="gmail_msg">Thanks.<u class="gmail_msg"></u><u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" class="gmail_msg">Patrick Agrain<u class="gmail_msg"></u><u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" class="gmail_msg"><u class="gmail_msg"></u> <u class="gmail_msg"></u></span></p>
<div class="gmail_msg">
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0cm 0cm 0cm" class="gmail_msg">
<p class="MsoNormal gmail_msg"><b class="gmail_msg"><span lang="FR" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"" class="gmail_msg">De :</span></b><span lang="FR" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"" class="gmail_msg"> coreboot [mailto:<a href="mailto:coreboot-bounces@coreboot.org" class="gmail_msg" target="_blank">coreboot-bounces@coreboot.org</a>]
<b class="gmail_msg">De la part de</b> Agrain Patrick<br class="gmail_msg">
<b class="gmail_msg">Envoyé :</b> jeudi 29 décembre 2016 09:43<br class="gmail_msg">
<b class="gmail_msg">À :</b> ron minnich; <a href="mailto:coreboot@coreboot.org" class="gmail_msg" target="_blank">coreboot@coreboot.org</a></span></p></div></div></div></div><div lang="EN-US" link="blue" vlink="purple" class="gmail_msg"><div class="m_7400901810251125195WordSection1 gmail_msg"><div class="gmail_msg"><div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0cm 0cm 0cm" class="gmail_msg"><p class="MsoNormal gmail_msg"><span lang="FR" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"" class="gmail_msg"><br class="gmail_msg">
<b class="gmail_msg">Objet :</b> Re: [coreboot] How to add a new SuperIO ?<u class="gmail_msg"></u><u class="gmail_msg"></u></span></p></div></div></div></div><div lang="EN-US" link="blue" vlink="purple" class="gmail_msg"><div class="m_7400901810251125195WordSection1 gmail_msg">
<p class="MsoNormal gmail_msg"><u class="gmail_msg"></u> <u class="gmail_msg"></u></p>
<p class="MsoNormal gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" class="gmail_msg">Hi Ron,<u class="gmail_msg"></u><u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" class="gmail_msg">Thanks for the advice.<u class="gmail_msg"></u><u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" class="gmail_msg">It would be the first time that I will push code into a GIT project with Gerrit. Therefore, let me a few moment to gather all required information to perform
this without disturbance for others.<u class="gmail_msg"></u><u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" class="gmail_msg">For the moment, I pulled the Coreboot project and add/modify the required files. Platform build is OK.<u class="gmail_msg"></u><u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" class="gmail_msg">Now, the push… if you have any checklist to follow, it could be helpful.<u class="gmail_msg"></u><u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" class="gmail_msg"><u class="gmail_msg"></u> <u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" class="gmail_msg">Best regards,<u class="gmail_msg"></u><u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" class="gmail_msg">Patrick Agrain<u class="gmail_msg"></u><u class="gmail_msg"></u></span></p>
<p class="MsoNormal gmail_msg"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d" class="gmail_msg"><u class="gmail_msg"></u> <u class="gmail_msg"></u></span></p>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0cm 0cm 0cm" class="gmail_msg">
<p class="MsoNormal gmail_msg"><b class="gmail_msg"><span lang="FR" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"" class="gmail_msg">De :</span></b><span lang="FR" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"" class="gmail_msg"> ron minnich [<a href="mailto:rminnich@gmail.com" class="gmail_msg" target="_blank">mailto:rminnich@gmail.com</a>]
<br class="gmail_msg">
<b class="gmail_msg">Envoyé :</b> vendredi 16 décembre 2016 19:18<br class="gmail_msg">
<b class="gmail_msg">À :</b> Agrain Patrick; <a href="mailto:coreboot@coreboot.org" class="gmail_msg" target="_blank">coreboot@coreboot.org</a><br class="gmail_msg">
<b class="gmail_msg">Objet :</b> Re: [coreboot] How to add a new SuperIO ?<u class="gmail_msg"></u><u class="gmail_msg"></u></span></p>
</div>
<p class="MsoNormal gmail_msg"><u class="gmail_msg"></u> <u class="gmail_msg"></u></p>
<div class="gmail_msg">
<p class="MsoNormal gmail_msg">it's way easier if you push your changes to gerrit marked as a WIP. People can see the code and will likely spot any problems very quickly.<u class="gmail_msg"></u><u class="gmail_msg"></u></p>
</div>
<p class="MsoNormal gmail_msg"><u class="gmail_msg"></u> <u class="gmail_msg"></u></p>
<div class="gmail_msg">
<div class="gmail_msg">
<p class="MsoNormal gmail_msg">On Fri, Dec 16, 2016 at 12:40 AM Agrain Patrick <<a href="mailto:patrick.agrain@al-enterprise.com" class="gmail_msg" target="_blank">patrick.agrain@al-enterprise.com</a>> wrote:<u class="gmail_msg"></u><u class="gmail_msg"></u></p>
</div>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0cm;margin-bottom:5.0pt" class="gmail_msg">
<p class="MsoNormal gmail_msg">Hi all,<br class="gmail_msg">
<br class="gmail_msg">
I'm trying to add a new superIO chip to the source tree.<br class="gmail_msg">
The chip is an EXAR XR28V932.<br class="gmail_msg">
I tried to take example of the existing superIO chips, like the i3100 and it8716 to compose a correct source tree as following:<br class="gmail_msg">
[agrain1@frilldlin059 coreboot]$ ls -als ./src/superio/exar/xr28v382/<br class="gmail_msg">
total 10<br class="gmail_msg">
1 drwxr-xr-x 2 agrain1 dhs2 512 Dec 16 09:03 .<br class="gmail_msg">
1 drwxr-xr-x 3 agrain1 dhs2 512 Dec 15 09:41 ..<br class="gmail_msg">
1 -rw-r--r-- 1 agrain1 dhs2 687 Dec 15 09:34 Makefile.inc<br class="gmail_msg">
3 -rw-r--r-- 1 agrain1 dhs2 2614 Dec 16 09:03 superio.c<br class="gmail_msg">
2 -rw-r--r-- 1 agrain1 dhs2 1287 Dec 15 16:28 xr28v382.h<br class="gmail_msg">
<br class="gmail_msg">
I modified the devicetree.cb of my board (based on an Intel Mohon Peak) as following:<br class="gmail_msg">
device pci 1f.0 on end # LPC bridge<br class="gmail_msg">
chip superio/exar/xr28v382 # Super I/O<br class="gmail_msg">
device pnp 2e.0 on # Com1<br class="gmail_msg">
io 0x60 = 0x3f8<br class="gmail_msg">
irq 0x70 = 4<br class="gmail_msg">
end<br class="gmail_msg">
device pnp 2e.1 off # Com2<br class="gmail_msg">
end<br class="gmail_msg">
device pnp 2e.8 off # Watchdog<br class="gmail_msg">
end<br class="gmail_msg">
end<br class="gmail_msg">
device pci 1f.3 on end # SMBus 0<br class="gmail_msg">
<br class="gmail_msg">
Now the output of the console log (DEBUG level):<br class="gmail_msg">
<...><br class="gmail_msg">
PCI: pci_scan_bus for bus 00<br class="gmail_msg">
PCI: 00:00.0 [8086/1f0f] enabled<br class="gmail_msg">
PCI: Static device PCI: 00:01.0 not found, disabling it.<br class="gmail_msg">
child PNP: 002e.0 not a PCI device<br class="gmail_msg">
child PNP: 002e.1 not a PCI device<br class="gmail_msg">
child PNP: 002e.8 not a PCI device<br class="gmail_msg">
child PNP: 002e.0 not a PCI device<br class="gmail_msg">
child PNP: 002e.1 not a PCI device<br class="gmail_msg">
child PNP: 002e.8 not a PCI device<br class="gmail_msg">
child PNP: 002e.0 not a PCI device<br class="gmail_msg">
child PNP: 002e.1 not a PCI device<br class="gmail_msg">
child PNP: 002e.8 not a PCI device<br class="gmail_msg">
child PNP: 002e.0 not a PCI device<br class="gmail_msg">
<...><br class="gmail_msg">
PCI: 00:1f.0 [8086/1f38] enabled<br class="gmail_msg">
child PNP: 002e.0 not a PCI device<br class="gmail_msg">
child PNP: 002e.1 not a PCI device<br class="gmail_msg">
child PNP: 002e.8 not a PCI device<br class="gmail_msg">
child PNP: 002e.0 not a PCI device<br class="gmail_msg">
child PNP: 002e.1 not a PCI device<br class="gmail_msg">
child PNP: 002e.8 not a PCI device<br class="gmail_msg">
child PNP: 002e.0 not a PCI device<br class="gmail_msg">
child PNP: 002e.1 not a PCI device<br class="gmail_msg">
child PNP: 002e.8 not a PCI device<br class="gmail_msg">
PCI: 00:1f.3 [8086/1f3c] enabled<br class="gmail_msg">
child PNP: 002e.0 not a PCI device<br class="gmail_msg">
<...><br class="gmail_msg">
PCI: Left over static devices:<br class="gmail_msg">
PNP: 002e.0<br class="gmail_msg">
PNP: 002e.1<br class="gmail_msg">
PNP: 002e.8<br class="gmail_msg">
PCI: Check your devicetree.cb.<br class="gmail_msg">
PCI: pci_scan_bus for bus 01<br class="gmail_msg">
<...><br class="gmail_msg">
DOMAIN: 0000 (Intel Rangeley Northbridge)<br class="gmail_msg">
PCI: 00:00.0 (Intel Rangeley Northbridge)<br class="gmail_msg">
PCI: 00:01.0 (Intel Rangeley Northbridge)<br class="gmail_msg">
PCI: 00:02.0 (Intel Rangeley Northbridge)<br class="gmail_msg">
PCI: 00:03.0 (Intel Rangeley Northbridge)<br class="gmail_msg">
PCI: 00:04.0 (Intel Rangeley Northbridge)<br class="gmail_msg">
PCI: 00:0b.0 (Intel Rangeley Southbridge)<br class="gmail_msg">
PCI: 00:0e.0 (Intel Rangeley Southbridge)<br class="gmail_msg">
PCI: 00:13.0 (Intel Rangeley Southbridge)<br class="gmail_msg">
PCI: 00:14.0 (Intel Rangeley Southbridge)<br class="gmail_msg">
PCI: 00:14.1 (Intel Rangeley Southbridge)<br class="gmail_msg">
PCI: 00:14.2 (Intel Rangeley Southbridge)<br class="gmail_msg">
PCI: 00:14.3 (Intel Rangeley Southbridge)<br class="gmail_msg">
PCI: 00:16.0 (Intel Rangeley Southbridge)<br class="gmail_msg">
PCI: 00:17.0 (Intel Rangeley Southbridge)<br class="gmail_msg">
PCI: 00:18.0 (Intel Rangeley Southbridge)<br class="gmail_msg">
PCI: 00:1f.0 (Intel Rangeley Southbridge)<br class="gmail_msg">
PNP: 002e.0 (EXAR XR28V382 Super I/O)<br class="gmail_msg">
PNP: 002e.1 (EXAR XR28V382 Super I/O)<br class="gmail_msg">
PNP: 002e.8 (EXAR XR28V382 Super I/O)<br class="gmail_msg">
PCI: 00:1f.3 (Intel Rangeley Southbridge)<br class="gmail_msg">
PCI: 00:0f.0 (unknown)<br class="gmail_msg">
PCI: 01:00.0 (unknown)<br class="gmail_msg">
<br class="gmail_msg">
I guess that the "" are not normal, isn't it ?<br class="gmail_msg">
And so the " Check your devicetree.cb." ?<br class="gmail_msg">
Moreover, I put a printk() in the init function of the chip and do not see it in the log.<br class="gmail_msg">
What particular point should I also check to be sure that I do not miss anything ?<br class="gmail_msg">
<br class="gmail_msg">
Thanks for your help.<br class="gmail_msg">
Best regards,<br class="gmail_msg">
Patrick Agrain<br class="gmail_msg">
<br class="gmail_msg">
--<br class="gmail_msg">
coreboot mailing list: <a href="mailto:coreboot@coreboot.org" class="gmail_msg" target="_blank">coreboot@coreboot.org</a><br class="gmail_msg">
<a href="https://www.coreboot.org/mailman/listinfo/coreboot" class="gmail_msg" target="_blank">https://www.coreboot.org/mailman/listinfo/coreboot</a><u class="gmail_msg"></u><u class="gmail_msg"></u></p>
</blockquote>
</div>
</div></div>
--<br class="gmail_msg">
coreboot mailing list: <a href="mailto:coreboot@coreboot.org" class="gmail_msg" target="_blank">coreboot@coreboot.org</a><br class="gmail_msg">
<a href="https://www.coreboot.org/mailman/listinfo/coreboot" rel="noreferrer" class="gmail_msg" target="_blank">https://www.coreboot.org/mailman/listinfo/coreboot</a></blockquote></div>