[flashrom] [commit] r887 - trunk
Luc Verhaegen
libv at skynet.be
Thu Feb 4 03:32:34 CET 2010
On Mon, Feb 01, 2010 at 02:53:30AM +0100, Luc Verhaegen wrote:
> On Sun, Jan 31, 2010 at 10:27:35PM +0100, Luc Verhaegen wrote:
> > On Sun, Jan 31, 2010 at 09:13:07PM +0100, repository service wrote:
> > > Author: uwe
> > > Date: Sun Jan 31 21:13:06 2010
> > > New Revision: 887
> > > URL: http://flashrom.org/trac/coreboot/changeset/887
> > >
> > > Log:
> > > Add the Tekram P6Pro-A5 board as supported (trivial).
> > >
> > > The board doesn't need a board-enable, writing works out of the box.
> > >
> > > Also, the board can only decode 256KB. I verified this by writing a 512KB
> > > image of random bytes (which fails), whereas 256KB of random bytes can be
> > > written correctly.
> > >
> > > Signed-off-by: Uwe Hermann <uwe at hermann-uwe.de>
> > > Acked-by: Uwe Hermann <uwe at hermann-uwe.de>
> > >
> > > Modified:
> > > trunk/board_enable.c
> > > trunk/print_wiki.c
> > >
> > > Modified: trunk/board_enable.c
> > > ==============================================================================
> > > --- trunk/board_enable.c Fri Jan 29 00:55:12 2010 (r886)
> > > +++ trunk/board_enable.c Sun Jan 31 21:13:06 2010 (r887)
> > > @@ -1235,6 +1235,7 @@
> > > {0x10DE, 0x0050, 0x1297, 0x5036, 0x1412, 0x1724, 0x1297, 0x5036, NULL, NULL, NULL, "Shuttle", "FN25", 0, board_shuttle_fn25},
> > > {0x1106, 0x3038, 0x0925, 0x1234, 0x1106, 0x3058, 0x15DD, 0x7609, NULL, NULL, NULL, "Soyo", "SY-7VCA", 0, board_soyo_sy_7vca},
> > > {0x8086, 0x1076, 0x8086, 0x1176, 0x1106, 0x3059, 0x10f1, 0x2498, NULL, NULL, NULL, "Tyan", "S2498 (Tomcat K7M)", 0, w836xx_memw_enable_2e},
> > > + {0x1106, 0x3038, 0x0925, 0x1234, 0, 0, 0, 0, NULL, NULL, NULL, "Tekram", "P6Pro-A5", 256, NULL},
> > > {0x1106, 0x3177, 0x1106, 0xAA01, 0x1106, 0x3123, 0x1106, 0xAA01, NULL, NULL, NULL, "VIA", "EPIA M/MII/...", 0, via_vt823x_gpio15_raise},
> > > {0x1106, 0x0259, 0x1106, 0x3227, 0x1106, 0x3065, 0x1106, 0x3149, NULL, NULL, NULL, "VIA", "EPIA-N/NL", 0, via_vt823x_gpio9_raise},
> > > {0x1106, 0x5337, 0x1458, 0xb003, 0x1106, 0x287e, 0x1106, 0x337e, NULL, NULL, NULL, "VIA", "PC3500G", 0, it87xx_probe_spi_flash},
> >
> > Second set of ids.
> >
> > Luc Verhaegen.
>
> Also, where are the lspci -vvnnxxx; flashrom -V and superio -deV outputs
> that we require for board enables? I seem unable to find them on the
> list.
>
> Luc Verhaegen.
This is fair warning from the board enable gestapo.
There are issues with this code:
* no second set of IDs.
* no lspci dump.
* no superiotool dump.
* no flashrom -V output for dmi strings.
This pretty much breaches all existing board enable conventions. This is
exacerbated by the self-ack.
It is code from sunday, the issues here were flagged shortly after, but
are still not rectified. I therefor propose a direct revert of the board
enable line.
Luc Verhaegen.
More information about the flashrom
mailing list