[flashrom] [PATCH] Board enable for ASUS P4SD-LA (HP OEM)

Idwer Vollering vidwer at gmail.com
Sat Jul 24 20:32:48 CEST 2010


2010/7/24 Michael Karcher <flashrom at mkarcher.dialup.fu-berlin.de>

> Am Samstag, den 24.07.2010, 12:49 +0200 schrieb Carl-Daniel Hailfinger:
> > >> Signed-off-by: Michael Karcher <flashrom at mkarcher.dialup.fu-berlin.de
> >
> > (No response in 3 months, please commit as NT)
> > Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006 at gmx.net>
>
> Thanks! Committed as r1101.
>

And that broke compilation:

cc -MMD -Os -Wall -Wshadow -Werror  -D'CONFIG_INTERNAL=1'
-D'CONFIG_SERPROG=1' -D'CONFIG_RAYER_SPI=1' -D'CONFIG_BITBANG_SPI=1'
-D'CONFIG_NIC3COM=1' -D'CONFIG_SATASII=1'  -D'CONFIG_DUMMY=1'
-D'CONFIG_DRKAISER=1' -D'CONFIG_NICREALTEK=1' -D'CONFIG_BUSPIRATE_SPI=1'
-D'NEED_PCI=1' -D'HAVE_UTSNAME=1' -D'FLASHROM_VERSION="0.9.2-r1102"' -o
board_enable.o -c board_enable.c
cc1: warnings being treated as errors
board_enable.c:1697:2: error: initialization from incompatible pointer type
make: *** [board_enable.o] Error 1

---

Index: board_enable.c
===================================================================
--- board_enable.c      (revision 1102)
+++ board_enable.c      (working copy)
@@ -1320,7 +1320,7 @@
 /**
  * Suited for P4SD-LA (HP OEM): i865 + ICH5
  */
-static int intel_ich_gpio32_raise(const char *name)
+static int intel_ich_gpio32_raise(void)
 {
        return intel_ich_gpio_set(32, 1);
 }


>
> Regards,
>   Michael Karcher
>

Signed-off-by: Idwer Vollering <vidwer at gmail.com>


>
> _______________________________________________
> flashrom mailing list
> flashrom at flashrom.org
> http://www.flashrom.org/mailman/listinfo/flashrom
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.flashrom.org/pipermail/flashrom/attachments/20100724/4b5a15ec/attachment.html>


More information about the flashrom mailing list