[coreboot-gerrit] Patch merged into coreboot/master: 8ecec21 Revert "siemens/sitemp_g1p1: Make ACPI report the right mmconf region"

gerrit at coreboot.org gerrit at coreboot.org
Fri Apr 12 11:48:16 CEST 2013


the following patch was just integrated into master:
commit 8ecec215be54fc15ba1cc6f2e5c452ffb833c29a
Author: Nico Huber <nico.h at gmx.de>
Date:   Wed Apr 10 19:14:41 2013 +0200

    Revert "siemens/sitemp_g1p1: Make ACPI report the right mmconf region"
    
    This reverts commit 1fde22c54cacb15493bbde8835ec9e20f1d39bf5:
    
        commit 1fde22c54cacb15493bbde8835ec9e20f1d39bf5
        Author: Patrick Georgi <patrick.georgi at secunet.com>
        Date:   Tue Apr 9 15:41:23 2013 +0200
    
            siemens/sitemp_g1p1: Make ACPI report the right mmconf region
    
            ACPI reported the entire space between top-of-memory and some
            (relatively) arbitrary limit as useful for MMIO. Unfortunately
            the HyperTransport configuration disagreed. Make them match up.
    
            Other boards are not affected since they don't report any region
            for that purpose at all (it seems).
    
            Change-Id: I432a679481fd1c271f14ecd6fe74f0b7a15a698e
            Signed-off-by: Patrick Georgi <patrick.georgi at secunet.com>
            Reviewed-on: http://review.coreboot.org/3047
            Tested-by: build bot (Jenkins)
            Reviewed-by: Ronald G. Minnich <rminnich at gmail.com>
    
    It sneaked in without it's dependencies and, therefore, broke the build for
    all amdk8 targets. Paul Menzel already commented on the issue in [1]. It
    also doesn't look like the dependencies would be pulled soon [2].
    
    [1] http://review.coreboot.org/#/c/3047/
    [2] http://review.coreboot.org/#/c/2662/
    
    Change-Id: Ica89563aae4af3f0f35cacfe37fb608782329523
    Signed-off-by: Nico Huber <nico.h at gmx.de>
    Reviewed-on: http://review.coreboot.org/3063
    Tested-by: build bot (Jenkins)
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-by: Patrick Georgi <patrick at georgi-clan.de>

Reviewed-By: Patrick Georgi <patrick at georgi-clan.de> at Fri Apr 12 11:48:14 2013, giving +2
See http://review.coreboot.org/3063 for details.

-gerrit



More information about the coreboot-gerrit mailing list