[coreboot-gerrit] New patch to review for coreboot: 3c40cac snow: Get rid of the oprom loaded GPIO.

Gabe Black (gabeblack@chromium.org) gerrit at coreboot.org
Tue Apr 16 06:01:21 CEST 2013


Gabe Black (gabeblack at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3094

-gerrit

commit 3c40cac347a1d717bd9118c1c534919cf6db00ec
Author: Gabe Black <gabeblack at chromium.org>
Date:   Mon Apr 15 19:07:10 2013 -0700

    snow: Get rid of the oprom loaded GPIO.
    
    ARM doesn't use option ROMs, so this value doesn't make sense.
    
    Change-Id: I1a0f0854e1dd4b9594ca0c147e590337520436da
    Signed-off-by: Gabe Black <gabeblack at chromium.org>
---
 src/mainboard/google/snow/chromeos.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/src/mainboard/google/snow/chromeos.c b/src/mainboard/google/snow/chromeos.c
index ca105e7..e9e03aa 100644
--- a/src/mainboard/google/snow/chromeos.c
+++ b/src/mainboard/google/snow/chromeos.c
@@ -87,14 +87,6 @@ void fill_lb_gpios(struct lb_gpios *gpios)
 		GPIO_MAX_NAME_LENGTH);
 	count++;
 
-	/* Was VGA Option ROM loaded? */
-	gpios->gpios[count].port = -1; /* This is a pseudo GPIO */
-	gpios->gpios[count].polarity = ACTIVE_HIGH;
-	gpios->gpios[count].value = 0;
-	strncpy((char *)gpios->gpios[count].name, "oprom",
-		GPIO_MAX_NAME_LENGTH);
-	count++;
-
 	gpios->size = sizeof(*gpios) + (count * sizeof(struct lb_gpio));
 	gpios->count = count;
 



More information about the coreboot-gerrit mailing list