[coreboot-gerrit] New patch to review for coreboot: 3d5d6bd exynos5: eliminate lcd_base variable
David Hendricks (dhendrix@chromium.org)
gerrit at coreboot.org
Fri Apr 19 02:29:40 CEST 2013
David Hendricks (dhendrix at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3114
-gerrit
commit 3d5d6bd86958616c0e9f6bb9f5b027ddbae680f4
Author: David Hendricks <dhendrix at chromium.org>
Date: Thu Apr 18 17:27:07 2013 -0700
exynos5: eliminate lcd_base variable
The original imported code used "lcdbase" and "lcd_base" which quite
predictably caused confusion and bugs. Let's put an end to this little
bit of insanity.
Change-Id: I4f995482cfbff5f23bb296a1e6d35beccf5f8a91
Signed-off-by: David Hendricks <dhendrix at chromium.org>
---
src/cpu/samsung/exynos5-common/exynos-fb.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/cpu/samsung/exynos5-common/exynos-fb.c b/src/cpu/samsung/exynos5-common/exynos-fb.c
index 11d666b..54a2d7a 100644
--- a/src/cpu/samsung/exynos5-common/exynos-fb.c
+++ b/src/cpu/samsung/exynos5-common/exynos-fb.c
@@ -83,7 +83,6 @@ int lcd_line_length;
int lcd_color_fg;
int lcd_color_bg;
-void *lcd_base; /* Start of framebuffer memory */
void *lcd_console_address; /* Start of console buffer */
short console_col;
@@ -150,10 +149,10 @@ void fb_init(vidinfo_t *panel_info, void *lcdbase,
((pd->yres - 1) << LINEVAL_OFFSET);
writel(val, &disp_ctrl->vidtcon2);
- writel((unsigned int)lcd_base, &fimd->vidw00add0b0);
+ writel((unsigned int)lcdbase, &fimd->vidw00add0b0);
fbsize = calc_fbsize(panel_info);
- writel((unsigned int)lcd_base + fbsize, &fimd->vidw00add1b0);
+ writel((unsigned int)lcdbase + fbsize, &fimd->vidw00add1b0);
writel(pd->xres * 2, &fimd->vidw00add2);
More information about the coreboot-gerrit
mailing list