[coreboot-gerrit] Patch set updated for coreboot: 14ac3df Google/Snow: Clean up: remove unnecessary initialization in boot block.
Hung-Te Lin (hungte@chromium.org)
gerrit at coreboot.org
Mon Apr 29 18:06:59 CEST 2013
Hung-Te Lin (hungte at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3147
-gerrit
commit 14ac3dfd96f0c89531fa994e5073a605d13a7f23
Author: Hung-Te Lin <hungte at chromium.org>
Date: Mon Apr 29 22:20:35 2013 +0800
Google/Snow: Clean up: remove unnecessary initialization in boot block.
The SPI1 interface is already initialized by iROM.
The console_init has already printed some initialization message, so the "UART
initialized" message is also not required.
Verified by building and booting firmware image on Google/Snow successfully.
Change-Id: I89390506aa825397c0d7e52ad7503f1cb808f7db
Signed-off-by: Hung-Te Lin <hungte at chromium.org>
---
src/mainboard/google/snow/bootblock.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/mainboard/google/snow/bootblock.c b/src/mainboard/google/snow/bootblock.c
index 09edbad..2d7beb1 100644
--- a/src/mainboard/google/snow/bootblock.c
+++ b/src/mainboard/google/snow/bootblock.c
@@ -40,12 +40,14 @@ void bootblock_mainboard_init(void)
* We want to do this as early as we can.
*/
timer_start();
- exynos_pinmux_config(PERIPH_ID_SPI1, PINMUX_FLAG_NONE);
+ /* The boot device (ex, SPI1) is already initialized by
+ * iROM (which loads the bootblock) so we don't need to
+ * configure pinmux for it.
+ */
break;
}
#if CONFIG_EARLY_CONSOLE
exynos_pinmux_config(PERIPH_ID_UART3, PINMUX_FLAG_NONE);
console_init();
- printk(BIOS_INFO, "\n\n\n%s: UART initialized\n", __func__);
#endif
}
More information about the coreboot-gerrit
mailing list