[coreboot-gerrit] New patch to review for coreboot: 8bfd3e2 Make EARLY_CONSOLE optional

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Fri Aug 2 11:07:25 CEST 2013


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3846

-gerrit

commit 8bfd3e281e5db6bed5dd1f85ad17eac748a5ad4f
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Wed Jul 31 20:52:04 2013 +0300

    Make EARLY_CONSOLE optional
    
    This change brings back the possibility to disable console
    output while in romstage, like before commit d2f45c65.
    
    For some platforms (AMD multi-socket) USBDEBUG and/or CBMEM
    CONSOLE do not work correctly for romstage due the way
    cache-as-ram is set up, but might already work for ramstage.
    
    Change-Id: Id8d830e02a18129af419d3b5860866acf315d531
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/console/Kconfig | 1 +
 src/cpu/Kconfig     | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/console/Kconfig b/src/console/Kconfig
index 013b72f..1d050f7 100644
--- a/src/console/Kconfig
+++ b/src/console/Kconfig
@@ -9,6 +9,7 @@ config BOOTBLOCK_CONSOLE
 
 config EARLY_CONSOLE
 	bool "Enable early (pre-RAM) console output."
+	default y if CACHE_AS_RAM
 	default n
 	help
 	  Use console during early (pre-RAM) boot stages
diff --git a/src/cpu/Kconfig b/src/cpu/Kconfig
index 9d268e4..e48fe87 100644
--- a/src/cpu/Kconfig
+++ b/src/cpu/Kconfig
@@ -20,7 +20,6 @@ source src/cpu/x86/Kconfig
 
 config CACHE_AS_RAM
 	bool
-	select EARLY_CONSOLE
 	default !ROMCC
 
 config DCACHE_RAM_BASE



More information about the coreboot-gerrit mailing list