[coreboot-gerrit] New patch to review for coreboot: 3beceac emulation/qemu-i440fx: style cleanup

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Thu Aug 15 20:42:02 CEST 2013


Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3873

-gerrit

commit 3beceac1be1d5378c97026d9ce5fda80e8e88c2c
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Thu Aug 15 20:41:15 2013 +0200

    emulation/qemu-i440fx: style cleanup
    
    Drop unused and commented out variable, and fix a comment while at it.
    
    Change-Id: I1bd7d10aca949c8579433ea1c91264fd816a3fb4
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
---
 src/mainboard/emulation/qemu-i440fx/northbridge.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/mainboard/emulation/qemu-i440fx/northbridge.c b/src/mainboard/emulation/qemu-i440fx/northbridge.c
index c08d59e..2ea4a68 100644
--- a/src/mainboard/emulation/qemu-i440fx/northbridge.c
+++ b/src/mainboard/emulation/qemu-i440fx/northbridge.c
@@ -54,7 +54,6 @@ static void cpu_pci_domain_read_resources(struct device *dev)
 {
 	u16 nbid   = pci_read_config16(dev_find_slot(0, 0), PCI_DEVICE_ID);
 	int i440fx = (nbid == 0x1237);
-//	int q35    = (nbid == 0x29c0);
 	struct resource *res;
 	unsigned long tomk = 0, high;
 	int idx = 10;
@@ -94,7 +93,7 @@ static void cpu_pci_domain_read_resources(struct device *dev)
 
 	if (i440fx) {
 		/* Reserve space for the IOAPIC.  This should be in
-		 * the Southbridge, but I couldn't tell which device
+		 * the southbridge, but I couldn't tell which device
 		 * to put it in. */
 		res = new_resource(dev, 2);
 		res->base = IO_APIC_ADDR;



More information about the coreboot-gerrit mailing list