[coreboot-gerrit] New patch to review for coreboot: ce955f5 ARM: Remove (NOLOAD) from the .car section
Stefan Reinauer (stefan.reinauer@coreboot.org)
gerrit at coreboot.org
Tue Dec 3 23:56:31 CET 2013
Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4435
-gerrit
commit ce955f50d95a3bfd7b143a37270d8df54cf282fb
Author: Gabe Black <gabeblack at google.com>
Date: Tue Aug 6 04:30:13 2013 -0700
ARM: Remove (NOLOAD) from the .car section
On ARM, if the .car section is marked as NOLOAD, there's nothing that sets it
to zero. Some code in the cbmem console depends on a global variable being
zero initially, and if that's not true bad things happen.
Change-Id: Ic72a9fb0ee0c5a608190be6f24d0d7de7c34fc1f
Signed-off-by: Gabe Black <gabeblack at google.com>
Reviewed-on: https://gerrit.chromium.org/gerrit/64769
Reviewed-by: Stefan Reinauer <reinauer at google.com>
Commit-Queue: Gabe Black <gabeblack at chromium.org>
Tested-by: Gabe Black <gabeblack at chromium.org>
---
src/arch/armv7/romstage.ld | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/arch/armv7/romstage.ld b/src/arch/armv7/romstage.ld
index 11a91cf..459f714 100644
--- a/src/arch/armv7/romstage.ld
+++ b/src/arch/armv7/romstage.ld
@@ -74,7 +74,7 @@ SECTIONS
_ebss = .;
- .car.data . (NOLOAD) : {
+ .car.data . : {
. = ALIGN(8);
_car_data_start = .;
*(.car.global_data);
More information about the coreboot-gerrit
mailing list