[coreboot-gerrit] Patch set updated for coreboot: 960f7d1 intel/fsp_bd82x6x: Use correct type pointer for mainboard_smi_gpi

Alexandru Gagniuc (mr.nuke.me@gmail.com) gerrit at coreboot.org
Thu Dec 5 02:53:06 CET 2013


Alexandru Gagniuc (mr.nuke.me at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4479

-gerrit

commit 960f7d12a6c95dc4a928a77f3bb8a9d455a0ec2a
Author: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Date:   Wed Dec 4 19:32:23 2013 -0600

    intel/fsp_bd82x6x: Use correct type pointer for mainboard_smi_gpi
    
    mainboard_smi_gpi has recently been updated to take a u32 argument from a
    u16, but the patch introducing the fsp_bd82x6x support has been verified
    on a master before this change, thus resulting in a 'cast from incompatible
    type' error. Update the pointer to the correct size argument.
    
    Change-Id: I9d62ee43f7c8ed774898f54d29a87cf463b76e91
    Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>
---
 src/southbridge/intel/fsp_bd82x6x/smihandler.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/southbridge/intel/fsp_bd82x6x/smihandler.c b/src/southbridge/intel/fsp_bd82x6x/smihandler.c
index 121854b..8ff36e6 100644
--- a/src/southbridge/intel/fsp_bd82x6x/smihandler.c
+++ b/src/southbridge/intel/fsp_bd82x6x/smihandler.c
@@ -576,7 +576,7 @@ static void southbridge_smi_gpe0(unsigned int node, smm_state_save_area_t *state
 
 static void southbridge_smi_gpi(unsigned int node, smm_state_save_area_t *state_save)
 {
-	void (*mainboard_gpi)(u16 gpi_sts) = mainboard_smi_gpi;
+	void (*mainboard_gpi)(u32 gpi_sts) = mainboard_smi_gpi;
 	u16 reg16;
 	reg16 = inw(pmbase + ALT_GP_SMI_STS);
 	outw(reg16, pmbase + ALT_GP_SMI_STS);



More information about the coreboot-gerrit mailing list