[coreboot-gerrit] New patch to review for coreboot: 41c7eac sconfig: avoid regenerating the binary all the time

Patrick Georgi (patrick@georgi-clan.de) gerrit at coreboot.org
Thu Dec 5 20:19:10 CET 2013


Patrick Georgi (patrick at georgi-clan.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4486

-gerrit

commit 41c7eac1bdba578715cefd716d9878665a47bed9
Author: Patrick Georgi <patrick at georgi-clan.de>
Date:   Thu Dec 5 20:17:36 2013 +0100

    sconfig: avoid regenerating the binary all the time
    
    This makes USE_XARGS-abuild unhappy due to races
    
    Change-Id: I1237468366c7f8af7eacd572c2bd32df9a3d58ca
    Signed-off-by: Patrick Georgi <patrick at georgi-clan.de>
---
 util/sconfig/Makefile.inc | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/util/sconfig/Makefile.inc b/util/sconfig/Makefile.inc
index 97a445f..f3e8bda 100644
--- a/util/sconfig/Makefile.inc
+++ b/util/sconfig/Makefile.inc
@@ -8,7 +8,10 @@ SCONFIGFLAGS += -I$(top)/util/sconfig -I$(objutil)/sconfig
 $(objutil)/sconfig:
 	mkdir -p $@
 
-$(objutil)/sconfig/%.o: util/sconfig/%.c
+$(objutil)/sconfig/.generated: $(objutil)/sconfig
+	touch $@
+
+$(objutil)/sconfig/%.o: util/sconfig/%.c | $(objutil)/sconfig/.generated
 	printf "    HOSTCC     $(subst $(obj)/,,$(@))\n"
 	$(HOSTCC) $(SCONFIGFLAGS) $(HOSTCFLAGS) -c -o $@ $<
 
@@ -35,6 +38,6 @@ $(objutil)/sconfig/%: $(top)/util/sconfig/%_shipped
 	mkdir -p $(dir $@)
 	cp $< $@
 
-$(objutil)/sconfig/sconfig: $(objutil)/sconfig $(addprefix $(objutil)/sconfig/,$(sconfigobj))
+$(objutil)/sconfig/sconfig: $(addprefix $(objutil)/sconfig/,$(sconfigobj))
 	printf "    HOSTCC     $(subst $(obj)/,,$(@)) (link)\n"
 	$(HOSTCC) $(SCONFIGFLAGS) -o $@ $(addprefix $(objutil)/sconfig/,$(sconfigobj))



More information about the coreboot-gerrit mailing list