[coreboot-gerrit] Patch merged into coreboot/master: 7b56cc5 Do not export variables to GRUB build

gerrit at coreboot.org gerrit at coreboot.org
Fri Dec 6 16:38:53 CET 2013


the following patch was just integrated into master:
commit 7b56cc5937a31ea05218b89f13aed14c11a2d53a
Author: Vladimir Serbinenko <phcoder at gmail.com>
Date:   Tue Dec 3 18:22:44 2013 +0100

    Do not export variables to GRUB build
    
    Variables in coreboot and not in line with GRUB ones. E.g. HOSTCC is both
    HOST_CC and BUILD_CC for GRUB (consult INSTALL for more details) and
    what coreboot calls CC is TARGET_CC for GRUB.
    
    Current code plugs this by defining variables explicitly but it has a nasty
    effect that make stops caring about flags added in makefile itself. Undef
    as many variables as possible but still pass them to configure for them to
    have correct effect and keep CC assignment as my make version doesn't undefine
    it even when instructed to do so.
    
    Tested with qemu.
    
    Change-Id: I9d18f557138a20ae3918d698dee8f5b5c5738f75
    Signed-off-by: Vladimir Serbinenko <phcoder at gmail.com>


See http://review.coreboot.org/4310 for details.

-gerrit



More information about the coreboot-gerrit mailing list