[coreboot-gerrit] Patch set updated for coreboot: 9f90446 snow: Fix the edid data structure definition so depthcharge works again.

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Sat Dec 7 04:37:44 CET 2013


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4341

-gerrit

commit 9f904460e0fe3f0afb51d6960d39df2b67b8f45d
Author: Gabe Black <gabeblack at google.com>
Date:   Sun Jul 7 04:05:51 2013 -0700

    snow: Fix the edid data structure definition so depthcharge works again.
    
    Some new fields were added to the edid data structure, and the edid code was
    changed to put estimated values into those fields which were ultimately passed
    into depthcharge or other payloads. On snow we do things different and just
    declare an edid structure statically which didn't have those members. The rows
    and columns of the graphics console were 0, and that confused the framebuffer
    driver and made it loop forever.
    
    Change-Id: I6ca3bd948482b347a6a981e83b82b10dca995e5e
    Signed-off-by: Gabe Black <gabeblack at google.com>
    Reviewed-on: https://gerrit.chromium.org/gerrit/61057
    Reviewed-by: Ronald G. Minnich <rminnich at chromium.org>
    Commit-Queue: Gabe Black <gabeblack at chromium.org>
    Tested-by: Gabe Black <gabeblack at chromium.org>
---
 src/mainboard/google/snow/mainboard.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/mainboard/google/snow/mainboard.c b/src/mainboard/google/snow/mainboard.c
index 93cc303..0d194b4 100644
--- a/src/mainboard/google/snow/mainboard.c
+++ b/src/mainboard/google/snow/mainboard.c
@@ -47,6 +47,9 @@ static struct edid edid = {
 	.ha = 1366,
 	.va = 768,
 	.bpp = 16,
+	.x_resolution = 1366,
+	.y_resolution = 768,
+	.bytes_per_line = 2 * 1366
 };
 
 /* TODO: transplanted DP stuff, clean up once we have something that works */



More information about the coreboot-gerrit mailing list