[coreboot-gerrit] Patch set updated for coreboot: 7f4bb74 Log device path during resource allocation

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Sat Dec 7 04:43:02 CET 2013


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4349

-gerrit

commit 7f4bb74e7d39fa53372aefccceaa6c95e0d1a806
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Tue Jul 9 10:46:52 2013 -0700

    Log device path during resource allocation
    
    Systems are hanging in dev_configure() without a log to
    indicate which device is being processed.  Add some logging
    points to save the device path before talking to the device
    so we can narrow in on which device is the problem.
    
    Change-Id: I3751c19a1ea68cdccbc33e4f6b2eeddd1bd9f2e4
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Reviewed-on: https://gerrit.chromium.org/gerrit/61296
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>
---
 src/device/device.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/device/device.c b/src/device/device.c
index 8bde663..9e06810 100644
--- a/src/device/device.c
+++ b/src/device/device.c
@@ -215,12 +215,14 @@ static void read_resources(struct bus *bus)
 			       dev_path(curdev));
 			continue;
 		}
+		post_log_path(curdev);
 		curdev->ops->read_resources(curdev);
 
 		/* Read in the resources behind the current device's links. */
 		for (link = curdev->link_list; link; link = link->next)
 			read_resources(link);
 	}
+	post_log_clear();
 	printk(BIOS_SPEW, "%s read_resources bus %d link: %d done\n",
 	       dev_path(bus->dev), bus->secondary, bus->link_num);
 }
@@ -1027,6 +1029,7 @@ void dev_configure(void)
 	for (child = root->link_list->children; child; child = child->sibling) {
 		if (!(child->path.type == DEVICE_PATH_DOMAIN))
 			continue;
+		post_log_path(child);
 		for (res = child->resource_list; res; res = res->next) {
 			if (res->flags & IORESOURCE_FIXED)
 				continue;
@@ -1073,6 +1076,7 @@ void dev_configure(void)
 	for (child = root->link_list->children; child; child = child->sibling) {
 		if (!(child->path.type == DEVICE_PATH_DOMAIN))
 			continue;
+		post_log_path(child);
 		for (res = child->resource_list; res; res = res->next) {
 			if (res->flags & IORESOURCE_FIXED)
 				continue;



More information about the coreboot-gerrit mailing list