[coreboot-gerrit] Patch merged into coreboot/master: 341ec18 cbfstool: Properly handle EOF in update_fit step

gerrit at coreboot.org gerrit at coreboot.org
Mon Dec 9 17:34:27 CET 2013


the following patch was just integrated into master:
commit 341ec183e056af4935f46b15e4649298b4d86903
Author: Alexandru Gagniuc <mr.nuke.me at gmail.com>
Date:   Sun Dec 8 17:46:40 2013 -0600

    cbfstool: Properly handle EOF in update_fit step
    
    During the update_fit step, 'file_length' is used to determine how many
    bytes are left in the CBFS file. It was decremented in a loop from an
    array 'mcus[num_mcus].size', but 'num_mcus' was incremented right before.
    Since 'mcus' is memset(0) externally, 'file_length' was never decremented.
    
    The loop exited when it reached a dummy terminator, usually 48 bytes of 0
    which are internationally added to microcode blobs in coreboot. However,
    if that terminator is removed, the loop doesn't stop and continues until
    it segfaults.
    
    Change-Id: I840727add69379ffef75b694d90402ed89769e3b
    Signed-off-by: Alexandru Gagniuc <mr.nuke.me at gmail.com>


See http://review.coreboot.org/4508 for details.

-gerrit



More information about the coreboot-gerrit mailing list