[coreboot-gerrit] New patch to review for coreboot: cac276c AMD fam10: Drop RAMINIT_SYSINFO

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Sun Dec 29 11:22:47 CET 2013


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4581

-gerrit

commit cac276cfb2d8ed7c2bbbf8444785d620e068769b
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Fri Dec 27 14:46:32 2013 +0200

    AMD fam10: Drop RAMINIT_SYSINFO
    
    AMD fam10 raminit cannot be built without RAMINIT_SYSINFO, this
    is not a true option but copy-paste remainder from AMD K8.
    
    Change-Id: Id8edc112f3bacebd1732304ac9ee6e77cc6263b7
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/cpu/amd/model_10xxx/init_cpus.c               | 8 +-------
 src/mainboard/advansus/a785e-i/Kconfig            | 1 -
 src/mainboard/amd/bimini_fam10/Kconfig            | 1 -
 src/mainboard/amd/mahogany_fam10/Kconfig          | 1 -
 src/mainboard/amd/serengeti_cheetah_fam10/Kconfig | 1 -
 src/mainboard/amd/tilapia_fam10/Kconfig           | 1 -
 src/mainboard/asus/m4a78-em/Kconfig               | 1 -
 src/mainboard/asus/m4a785-m/Kconfig               | 1 -
 src/mainboard/asus/m4a785t-m/Kconfig              | 1 -
 src/mainboard/asus/m5a88-v/Kconfig                | 1 -
 src/mainboard/avalue/eax-785e/Kconfig             | 1 -
 src/mainboard/gigabyte/ma785gm/Kconfig            | 1 -
 src/mainboard/gigabyte/ma785gmt/Kconfig           | 1 -
 src/mainboard/gigabyte/ma78gm/Kconfig             | 1 -
 src/mainboard/hp/dl165_g6_fam10/Kconfig           | 1 -
 src/mainboard/iei/kino-780am2-fam10/Kconfig       | 1 -
 src/mainboard/jetway/pa78vm5/Kconfig              | 1 -
 src/mainboard/msi/ms9652_fam10/Kconfig            | 1 -
 src/mainboard/supermicro/h8dmr_fam10/Kconfig      | 1 -
 src/mainboard/supermicro/h8qme_fam10/Kconfig      | 1 -
 src/mainboard/supermicro/h8scm_fam10/Kconfig      | 1 -
 src/mainboard/tyan/s2912_fam10/Kconfig            | 1 -
 src/southbridge/amd/cimx/sb700/early.c            | 2 --
 src/southbridge/amd/cimx/sb700/sb_cimx.h          | 2 --
 src/southbridge/amd/cimx/sb800/early.c            | 3 ---
 src/southbridge/amd/cimx/sb800/sb_cimx.h          | 2 --
 26 files changed, 1 insertion(+), 37 deletions(-)

diff --git a/src/cpu/amd/model_10xxx/init_cpus.c b/src/cpu/amd/model_10xxx/init_cpus.c
index a2f78d3..10c0c8a 100644
--- a/src/cpu/amd/model_10xxx/init_cpus.c
+++ b/src/cpu/amd/model_10xxx/init_cpus.c
@@ -244,11 +244,7 @@ static void STOP_CAR_AND_CPU(void)
 	stop_this_cpu();
 }
 
-#if CONFIG_RAMINIT_SYSINFO
 static u32 init_cpus(u32 cpu_init_detectedx, struct sys_info *sysinfo)
-#else
-static u32 init_cpus(u32 cpu_init_detectedx)
-#endif
 {
 	u32 bsp_apicid = 0;
 	u32 apicid;
@@ -903,16 +899,14 @@ static void finalize_node_setup(struct sys_info *sysinfo)
 {
 	u8 i;
 	u8 nodes = get_nodes();
-
-#if CONFIG_RAMINIT_SYSINFO
 	u32 reg;
+
 	/* read Node0 F0_0x64 bit [8:10] to find out SbLink # */
 	reg = pci_read_config32(NODE_HT(0), 0x64);
 	sysinfo->sblk = (reg >> 8) & 7;
 	sysinfo->sbbusn = 0;
 	sysinfo->nodes = nodes;
 	sysinfo->sbdn = get_sbdn(sysinfo->sbbusn);
-#endif
 
 	for (i = 0; i < nodes; i++) {
 		cpuSetAMDPCI(i);
diff --git a/src/mainboard/advansus/a785e-i/Kconfig b/src/mainboard/advansus/a785e-i/Kconfig
index c5d2f15..32500d6 100644
--- a/src/mainboard/advansus/a785e-i/Kconfig
+++ b/src/mainboard/advansus/a785e-i/Kconfig
@@ -22,7 +22,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select HAVE_MP_TABLE
 	select HAVE_ACPI_TABLES
 	select BOARD_ROMSIZE_KB_1024
-	select RAMINIT_SYSINFO
 	select ENABLE_APIC_EXT_ID
 	select GFXUMA
 	select HAVE_DEBUG_CAR
diff --git a/src/mainboard/amd/bimini_fam10/Kconfig b/src/mainboard/amd/bimini_fam10/Kconfig
index 5535980..a04c131 100644
--- a/src/mainboard/amd/bimini_fam10/Kconfig
+++ b/src/mainboard/amd/bimini_fam10/Kconfig
@@ -22,7 +22,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select SERIAL_CPU_INIT
 	select AMDMCT
 	select BOARD_ROMSIZE_KB_2048
-	select RAMINIT_SYSINFO
 	select ENABLE_APIC_EXT_ID
 	select GFXUMA
 	select HAVE_DEBUG_CAR
diff --git a/src/mainboard/amd/mahogany_fam10/Kconfig b/src/mainboard/amd/mahogany_fam10/Kconfig
index 7efc33f..2bc6a1d 100644
--- a/src/mainboard/amd/mahogany_fam10/Kconfig
+++ b/src/mainboard/amd/mahogany_fam10/Kconfig
@@ -19,7 +19,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select AMDMCT
 	select HAVE_ACPI_TABLES
 	select BOARD_ROMSIZE_KB_1024
-	select RAMINIT_SYSINFO
 	select ENABLE_APIC_EXT_ID
 	select GFXUMA
 	select QRANK_DIMM_SUPPORT
diff --git a/src/mainboard/amd/serengeti_cheetah_fam10/Kconfig b/src/mainboard/amd/serengeti_cheetah_fam10/Kconfig
index 4984b43..37cbfa4 100644
--- a/src/mainboard/amd/serengeti_cheetah_fam10/Kconfig
+++ b/src/mainboard/amd/serengeti_cheetah_fam10/Kconfig
@@ -18,7 +18,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select AMDMCT
 	select HAVE_ACPI_TABLES
 	select BOARD_ROMSIZE_KB_1024
-	select RAMINIT_SYSINFO
 	select ENABLE_APIC_EXT_ID
 	select LIFT_BSP_APIC_ID
 	select QRANK_DIMM_SUPPORT
diff --git a/src/mainboard/amd/tilapia_fam10/Kconfig b/src/mainboard/amd/tilapia_fam10/Kconfig
index 7d51968..111ac29 100644
--- a/src/mainboard/amd/tilapia_fam10/Kconfig
+++ b/src/mainboard/amd/tilapia_fam10/Kconfig
@@ -19,7 +19,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select AMDMCT
 	select HAVE_ACPI_TABLES
 	select BOARD_ROMSIZE_KB_1024
-	select RAMINIT_SYSINFO
 	select ENABLE_APIC_EXT_ID
 	select GFXUMA
 	select QRANK_DIMM_SUPPORT
diff --git a/src/mainboard/asus/m4a78-em/Kconfig b/src/mainboard/asus/m4a78-em/Kconfig
index 7ba70bd..197b3a0 100644
--- a/src/mainboard/asus/m4a78-em/Kconfig
+++ b/src/mainboard/asus/m4a78-em/Kconfig
@@ -18,7 +18,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select AMDMCT
 	select HAVE_ACPI_TABLES
 	select BOARD_ROMSIZE_KB_1024
-	select RAMINIT_SYSINFO
 	select ENABLE_APIC_EXT_ID
 	select GFXUMA
 	select QRANK_DIMM_SUPPORT
diff --git a/src/mainboard/asus/m4a785-m/Kconfig b/src/mainboard/asus/m4a785-m/Kconfig
index 13e30c9..f6ba242 100644
--- a/src/mainboard/asus/m4a785-m/Kconfig
+++ b/src/mainboard/asus/m4a785-m/Kconfig
@@ -19,7 +19,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select AMDMCT
 	select HAVE_ACPI_TABLES
 	select BOARD_ROMSIZE_KB_1024
-	select RAMINIT_SYSINFO
 	select ENABLE_APIC_EXT_ID
 	select GFXUMA
 	select QRANK_DIMM_SUPPORT
diff --git a/src/mainboard/asus/m4a785t-m/Kconfig b/src/mainboard/asus/m4a785t-m/Kconfig
index d9badee..af4fb7c 100644
--- a/src/mainboard/asus/m4a785t-m/Kconfig
+++ b/src/mainboard/asus/m4a785t-m/Kconfig
@@ -21,7 +21,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select AMDMCT
 	select HAVE_ACPI_TABLES
 	select BOARD_ROMSIZE_KB_1024
-	select RAMINIT_SYSINFO
 	select ENABLE_APIC_EXT_ID
 	select GFXUMA
 	select QRANK_DIMM_SUPPORT
diff --git a/src/mainboard/asus/m5a88-v/Kconfig b/src/mainboard/asus/m5a88-v/Kconfig
index 256add4..7ff25d4 100644
--- a/src/mainboard/asus/m5a88-v/Kconfig
+++ b/src/mainboard/asus/m5a88-v/Kconfig
@@ -20,7 +20,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select HAVE_MP_TABLE
 	select HAVE_ACPI_TABLES
 	select BOARD_ROMSIZE_KB_2048
-	select RAMINIT_SYSINFO
 	select ENABLE_APIC_EXT_ID
 	select GFXUMA
 	select HAVE_DEBUG_CAR
diff --git a/src/mainboard/avalue/eax-785e/Kconfig b/src/mainboard/avalue/eax-785e/Kconfig
index bfae1ee..abfaaec 100644
--- a/src/mainboard/avalue/eax-785e/Kconfig
+++ b/src/mainboard/avalue/eax-785e/Kconfig
@@ -22,7 +22,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select HAVE_MP_TABLE
 	select HAVE_ACPI_TABLES
 	select BOARD_ROMSIZE_KB_2048
-	select RAMINIT_SYSINFO
 	select ENABLE_APIC_EXT_ID
 	select GFXUMA
 	select HAVE_DEBUG_CAR
diff --git a/src/mainboard/gigabyte/ma785gm/Kconfig b/src/mainboard/gigabyte/ma785gm/Kconfig
index 282387c..7582320 100644
--- a/src/mainboard/gigabyte/ma785gm/Kconfig
+++ b/src/mainboard/gigabyte/ma785gm/Kconfig
@@ -21,7 +21,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select BOARD_ROMSIZE_KB_1024
 	select ENABLE_APIC_EXT_ID
 	select GFXUMA
-	select RAMINIT_SYSINFO
 	select QRANK_DIMM_SUPPORT
 
 config MAINBOARD_DIR
diff --git a/src/mainboard/gigabyte/ma785gmt/Kconfig b/src/mainboard/gigabyte/ma785gmt/Kconfig
index f4c5fff..0ea4eb7 100644
--- a/src/mainboard/gigabyte/ma785gmt/Kconfig
+++ b/src/mainboard/gigabyte/ma785gmt/Kconfig
@@ -21,7 +21,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select BOARD_ROMSIZE_KB_1024
 	select ENABLE_APIC_EXT_ID
 	select GFXUMA
-	select RAMINIT_SYSINFO
 	select QRANK_DIMM_SUPPORT
 
 config MAINBOARD_DIR
diff --git a/src/mainboard/gigabyte/ma78gm/Kconfig b/src/mainboard/gigabyte/ma78gm/Kconfig
index 1582786..d663eca 100644
--- a/src/mainboard/gigabyte/ma78gm/Kconfig
+++ b/src/mainboard/gigabyte/ma78gm/Kconfig
@@ -21,7 +21,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select BOARD_ROMSIZE_KB_1024
 	select ENABLE_APIC_EXT_ID
 	select GFXUMA
-	select RAMINIT_SYSINFO
 	select QRANK_DIMM_SUPPORT
 
 config MAINBOARD_DIR
diff --git a/src/mainboard/hp/dl165_g6_fam10/Kconfig b/src/mainboard/hp/dl165_g6_fam10/Kconfig
index 7250017..b72b8dd 100644
--- a/src/mainboard/hp/dl165_g6_fam10/Kconfig
+++ b/src/mainboard/hp/dl165_g6_fam10/Kconfig
@@ -15,7 +15,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select HAVE_MP_TABLE
 	select LIFT_BSP_APIC_ID
 	select BOARD_ROMSIZE_KB_1024
-	select RAMINIT_SYSINFO
 	select ENABLE_APIC_EXT_ID
 	select AMDMCT
 	select QRANK_DIMM_SUPPORT
diff --git a/src/mainboard/iei/kino-780am2-fam10/Kconfig b/src/mainboard/iei/kino-780am2-fam10/Kconfig
index 891ed82..62c8671 100644
--- a/src/mainboard/iei/kino-780am2-fam10/Kconfig
+++ b/src/mainboard/iei/kino-780am2-fam10/Kconfig
@@ -19,7 +19,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select AMDMCT
 	select HAVE_ACPI_TABLES
 	select BOARD_ROMSIZE_KB_1024
-	select RAMINIT_SYSINFO
 	select ENABLE_APIC_EXT_ID
 	select GFXUMA
 	select QRANK_DIMM_SUPPORT
diff --git a/src/mainboard/jetway/pa78vm5/Kconfig b/src/mainboard/jetway/pa78vm5/Kconfig
index f1108e0..01c4a59 100644
--- a/src/mainboard/jetway/pa78vm5/Kconfig
+++ b/src/mainboard/jetway/pa78vm5/Kconfig
@@ -19,7 +19,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select AMDMCT
 	select HAVE_ACPI_TABLES
 	select BOARD_ROMSIZE_KB_1024
-	select RAMINIT_SYSINFO
 	select ENABLE_APIC_EXT_ID
 	select GFXUMA
 	select QRANK_DIMM_SUPPORT
diff --git a/src/mainboard/msi/ms9652_fam10/Kconfig b/src/mainboard/msi/ms9652_fam10/Kconfig
index ef8d339..8420523 100644
--- a/src/mainboard/msi/ms9652_fam10/Kconfig
+++ b/src/mainboard/msi/ms9652_fam10/Kconfig
@@ -16,7 +16,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select HAVE_ACPI_TABLES
 	select HAVE_OPTION_TABLE
 	select BOARD_ROMSIZE_KB_512
-	select RAMINIT_SYSINFO
 	select ENABLE_APIC_EXT_ID
 	select AMDMCT
 	select SB_HT_CHAIN_UNITID_OFFSET_ONLY
diff --git a/src/mainboard/supermicro/h8dmr_fam10/Kconfig b/src/mainboard/supermicro/h8dmr_fam10/Kconfig
index 4c9d3ea..2f48b32 100644
--- a/src/mainboard/supermicro/h8dmr_fam10/Kconfig
+++ b/src/mainboard/supermicro/h8dmr_fam10/Kconfig
@@ -17,7 +17,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select LIFT_BSP_APIC_ID
 	select AMDMCT
 	select BOARD_ROMSIZE_KB_1024
-	select RAMINIT_SYSINFO
 	select ENABLE_APIC_EXT_ID
 	select QRANK_DIMM_SUPPORT
 
diff --git a/src/mainboard/supermicro/h8qme_fam10/Kconfig b/src/mainboard/supermicro/h8qme_fam10/Kconfig
index 2a5441a..27172ff 100644
--- a/src/mainboard/supermicro/h8qme_fam10/Kconfig
+++ b/src/mainboard/supermicro/h8qme_fam10/Kconfig
@@ -16,7 +16,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select LIFT_BSP_APIC_ID
 	select AMDMCT
 	select BOARD_ROMSIZE_KB_1024
-	select RAMINIT_SYSINFO
 	select ENABLE_APIC_EXT_ID
 	select QRANK_DIMM_SUPPORT
 
diff --git a/src/mainboard/supermicro/h8scm_fam10/Kconfig b/src/mainboard/supermicro/h8scm_fam10/Kconfig
index 021ba87..87cfc73 100644
--- a/src/mainboard/supermicro/h8scm_fam10/Kconfig
+++ b/src/mainboard/supermicro/h8scm_fam10/Kconfig
@@ -21,7 +21,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select SERIAL_CPU_INIT
 	select AMDMCT
 	select BOARD_ROMSIZE_KB_2048
-	select RAMINIT_SYSINFO
 	select ENABLE_APIC_EXT_ID
 
 config MAINBOARD_DIR
diff --git a/src/mainboard/tyan/s2912_fam10/Kconfig b/src/mainboard/tyan/s2912_fam10/Kconfig
index eb083a6..a7f9954 100644
--- a/src/mainboard/tyan/s2912_fam10/Kconfig
+++ b/src/mainboard/tyan/s2912_fam10/Kconfig
@@ -15,7 +15,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy
 	select HAVE_MP_TABLE
 	select LIFT_BSP_APIC_ID
 	select BOARD_ROMSIZE_KB_1024
-	select RAMINIT_SYSINFO
 	select ENABLE_APIC_EXT_ID
 	select AMDMCT
 	select MMCONF_SUPPORT_DEFAULT
diff --git a/src/southbridge/amd/cimx/sb700/early.c b/src/southbridge/amd/cimx/sb700/early.c
index 13c6379..82c395b 100644
--- a/src/southbridge/amd/cimx/sb700/early.c
+++ b/src/southbridge/amd/cimx/sb700/early.c
@@ -27,7 +27,6 @@
 #include <console/loglevel.h>
 #include "smbus.h"
 
-#if CONFIG_RAMINIT_SYSINFO
 /**
  * @brief Get SouthBridge device number
  * @param[in] bus target bus number
@@ -45,7 +44,6 @@ u32 get_sbdn(u32 bus)
 	printk(BIOS_SPEW, "SB700 - Early.c - %s - End.\n", __func__);
 	return (dev >> 15) & 0x1f;
 }
-#endif
 
 /**
  * @brief Enable A-Link Express Configuration DMA Access.
diff --git a/src/southbridge/amd/cimx/sb700/sb_cimx.h b/src/southbridge/amd/cimx/sb700/sb_cimx.h
index d91cc51..ebfaca8 100644
--- a/src/southbridge/amd/cimx/sb700/sb_cimx.h
+++ b/src/southbridge/amd/cimx/sb700/sb_cimx.h
@@ -40,7 +40,6 @@ void sb_Late_Post(void);
 void sb7xx_51xx_enable_wideio(u8 wio_index, u16 base);
 void sb7xx_51xx_disable_wideio(u8 wio_index);
 
-#if CONFIG_RAMINIT_SYSINFO
 /**
  * @brief Get SouthBridge device number, called by finalize_node_setup()
  * @param[in] bus target bus number
@@ -48,4 +47,3 @@ void sb7xx_51xx_disable_wideio(u8 wio_index);
  */
 u32 get_sbdn(u32 bus);
 #endif
-#endif
diff --git a/src/southbridge/amd/cimx/sb800/early.c b/src/southbridge/amd/cimx/sb800/early.c
index 83087f5..40648ed 100644
--- a/src/southbridge/amd/cimx/sb800/early.c
+++ b/src/southbridge/amd/cimx/sb800/early.c
@@ -26,7 +26,6 @@
 #include "cfg.h"		/*sb800_cimx_config*/
 #include "cbmem.h"
 
-#if CONFIG_RAMINIT_SYSINFO
 /**
  * @brief Get SouthBridge device number
  * @param[in] bus target bus number
@@ -45,8 +44,6 @@ u32 get_sbdn(u32 bus)
 	printk(BIOS_DEBUG, "SB800 - %s - %s - End.\n", __FILE__, __func__);
 	return (dev >> 15) & 0x1f;
 }
-#endif
-
 
 /**
  * @brief South Bridge CIMx romstage entry,
diff --git a/src/southbridge/amd/cimx/sb800/sb_cimx.h b/src/southbridge/amd/cimx/sb800/sb_cimx.h
index 3bec5d8..6267e1c 100644
--- a/src/southbridge/amd/cimx/sb800/sb_cimx.h
+++ b/src/southbridge/amd/cimx/sb800/sb_cimx.h
@@ -40,7 +40,6 @@ int acpi_is_wakeup_early(void);
  */
 void sb800_clk_output_48Mhz(void);
 
-#if CONFIG_RAMINIT_SYSINFO
 /**
  * @brief Get SouthBridge device number, called by finalize_node_setup()
  * @param[in] bus target bus number
@@ -48,4 +47,3 @@ void sb800_clk_output_48Mhz(void);
  */
 u32 get_sbdn(u32 bus);
 #endif
-#endif



More information about the coreboot-gerrit mailing list