[coreboot-gerrit] Patch merged into coreboot/master: 4f78b18 fox_wtm2: First step support for coreboot-based graphics startup

gerrit at coreboot.org gerrit at coreboot.org
Tue Jul 9 22:16:38 CEST 2013


the following patch was just integrated into master:
commit 4f78b187499d8e1f4a2fe3dad8e0997c91f15762
Author: Ronald G. Minnich <rminnich at google.com>
Date:   Wed Apr 17 16:57:30 2013 -0700

    fox_wtm2: First step support for coreboot-based graphics startup
    
    This code is the initial version of FUI for haswell and wtm2.
    
    The code is simplified from before in many ways. I've gotten rid of
    the opcode table, because it obscured meaning and I don't think it is
    needed any more. Register sets, mainly used for reset, are just lines
    of code -- not many of them. There are a bunch of not-yet-documented
    registers here; the VBIOS seemed to think they were necessary and
    testing shows they seem to be right.
    
    As a bit of added paranoia, we always include the VBIOS code as our
    emergency recovery path. You have to run it now anyways, so this is no
    regression from our current situation; and, if all goes well, in a
    week (or so), you'll never have to run it again, but like the Force
    and nose hair, it will be with you always.
    
    The code can return in three ways. The first, best way is success:
    panel is up and the VBIOS need not run. The second mode is that we
    tried to light up the panel but could not, for some reason, but will
    return with the panel partly up. In this case, it's ok not to power
    cycle the panel. The third, worst case, which will NEVER happen, ha
    ha, is that we have to turn the panel off and wait the required 600ms
    for it to cycle. Life sucks sometimes. This failure mode is in the
    'hang on we're going to fix it' category now that we have ramstage in
    RW.
    
    The Big Goal here is to create something other coreboot ports can use
    as well. The guys doing the x60 report that the link FUI works,
    without too many mods, on that chipset, so it seems Intel is keeping
    things from changing too much over time.
    
    Also, again, please note: this and the next 3 versions will ALWAYS fail.
    The goal is to verify the correctness of the recovery path.
    
    The bizarre tab-space formatting in drm_dp_helper.h is from the original,
    as in i915_reg.h
    
    Change-Id: I6ecf454633029d185c29d470980b5a0f3114a8ce
    Signed-off-by: Ronald G. Minnich <rminnich at google.com>
    Signed-off-by: Gabe Black <gabeblack at chromium.org>
    Reviewed-on: http://review.coreboot.org/3635
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/3635 for details.

-gerrit



More information about the coreboot-gerrit mailing list