[coreboot-gerrit] Patch set updated for coreboot: 9e1ffbb exynos5250: When enabling the I2S pins, turn off pull ups/downs.

Gabe Black (gabeblack@chromium.org) gerrit at coreboot.org
Wed Jul 10 14:32:07 CEST 2013


Gabe Black (gabeblack at chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3649

-gerrit

commit 9e1ffbba52d99440073384cbeb62508593769931
Author: Gabe Black <gabeblack at google.com>
Date:   Sat May 18 15:52:01 2013 -0700

    exynos5250: When enabling the I2S pins, turn off pull ups/downs.
    
    These pins will be driven by the internal controller which shouldn't have pull
    ups or downs in the pin fighting with them.
    
    Change-Id: I579aed84ace45d8f5f1d3ca64c064d98de842b57
    Signed-off-by: Gabe Black <gabeblack at chromium.org>
---
 src/cpu/samsung/exynos5250/pinmux.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/cpu/samsung/exynos5250/pinmux.c b/src/cpu/samsung/exynos5250/pinmux.c
index 6991dfc..9a473d0 100644
--- a/src/cpu/samsung/exynos5250/pinmux.c
+++ b/src/cpu/samsung/exynos5250/pinmux.c
@@ -286,8 +286,10 @@ int exynos_pinmux_config(enum periph_id peripheral, int flags)
 		gpio_set_pull(GPIO_X07, GPIO_PULL_NONE);
 		break;
 	case PERIPH_ID_I2S1:
-		for (i = 0; i < 5; i++)
+		for (i = 0; i < 5; i++) {
 			gpio_cfg_pin(GPIO_B00 + i, GPIO_FUNC(0x02));
+			gpio_set_pull(GPIO_B00 + i, GPIO_PULL_NONE);
+		}
 		break;
 	default:
 		printk(BIOS_DEBUG, "%s: invalid peripheral %d", __func__, peripheral);



More information about the coreboot-gerrit mailing list