[coreboot-gerrit] Patch merged into coreboot/master: fb37013 ARM: Fix the way the space for the page tables is allocated.

gerrit at coreboot.org gerrit at coreboot.org
Wed Jul 10 20:11:33 CEST 2013


the following patch was just integrated into master:
commit fb370130f6618d53f506566737f7394ee1417c55
Author: Gabe Black <gabeblack at google.com>
Date:   Sat May 18 21:41:59 2013 -0700

    ARM: Fix the way the space for the page tables is allocated.
    
    The page tables need to be aligned to a 16KB boundary and are 16KB in size.
    The CBMEM allocator only guarantees 512 byte alignment, so to make sure
    things are where they're supposed to be, the code was allocating extra space
    and then adjusting the pointer upwards. Unfortunately, it was adding the size
    of the table to the pointer first, then aligning it. Since it allocated twice
    the space of the table, this had the effect of moving past the first table
    size region of bytes, and then aligning upwards, pushing the end of the table
    out of the space allocated for it.
    
    You can get away with this if you push things you don't care about off the
    end, and it happened to be the case that we were allocating a color map we
    weren't using at the start of the next part of cbmem.
    
    Change-Id: I6b196fc573801b02f27f2e667acbf06163266651
    Signed-off-by: Gabe Black <gabeblack at chromium.org>
    Reviewed-on: http://review.coreboot.org/3651
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See http://review.coreboot.org/3651 for details.

-gerrit



More information about the coreboot-gerrit mailing list