[coreboot-gerrit] New patch to review for coreboot: c809210 util/cbfstool/cbfs_image.c: Store next entry in `next` so difference is not 0
Paul Menzel (paulepanter@users.sourceforge.net)
gerrit at coreboot.org
Sun Jul 14 10:43:23 CEST 2013
Paul Menzel (paulepanter at users.sourceforge.net) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3770
-gerrit
commit c80921039dc145550e05325cc0be276ffd88ee1b
Author: Paul Menzel <paulepanter at users.sourceforge.net>
Date: Sun Jul 14 10:37:10 2013 +0200
util/cbfstool/cbfs_image.c: Store next entry in `next` so difference is not 0
Currently `entry` is overwritten causing the difference to vanish
and resulting in a segmentation fault.
Change-Id: Ib563e0ba89f437c5f01c2bf8ed844735a528d2d2
Signed-off-by: Paul Menzel <paulepanter at users.sourceforge.net>
---
util/cbfstool/cbfs_image.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/cbfstool/cbfs_image.c b/util/cbfstool/cbfs_image.c
index eb9d574..ae4d69f 100644
--- a/util/cbfstool/cbfs_image.c
+++ b/util/cbfstool/cbfs_image.c
@@ -396,7 +396,7 @@ int cbfs_add_entry(struct cbfs_image *image, struct buffer *buffer,
// setup new entry
DEBUG("Setting new empty entry.\n");
- entry = cbfs_find_next_entry(image, entry);
+ next = cbfs_find_next_entry(image, entry);
new_size = (cbfs_get_entry_addr(image, next) -
cbfs_get_entry_addr(image, entry));
new_size -= cbfs_calculate_file_header_size("");
More information about the coreboot-gerrit
mailing list